Fix IntelliSense/MSVC errors and guard wxApp exception overrides#1326
Closed
Fix IntelliSense/MSVC errors and guard wxApp exception overrides#1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std::optionalappears missing and cascading syntax errors caused by MSVC using a lower language mode.overridediagnostics forwxAppexception hooks on builds where wxWidgets disables exception support.Description
/std:c++20viatarget_compile_optionsinCMakeLists.txtto enforce C++20 language mode for Visual Studio and align IntelliSense withcxx_std_20.MyApp::OnExceptionInMainLoopandMyApp::OnUnhandledExceptiondeclarations and definitions inmain.cppwith#if wxUSE_EXCEPTIONSso theoverridespecifier is only present when wx exception hooks are enabled.CMakeLists.txtandmain.cpp.Testing
tests/check_perastage_tree_modules.shand it passed (OK).tests/check_no_configmanager_get_in_gui.shand it passed (OK).cmake -S . -B build && cmake --build build -j4but a full local build could not complete in this environment due to missingwxWidgetsdevelopment packages, so full compile/link validation was not performed.Codex Task