Skip to content

Bronya e4 FUA always occurs #2

Description

@6000j

This one is a pretty simple one; Bronya's check in her allyTurn function doesn't actually check if self.eidolon >= 4, so she always uses the FUA.

While researching this bug I also found that according to the wiki Bronya's e4 FUA actually provides her 5 energy and currently it is implemented to provide her 0. I don't have e4 bronya or any way to test that the wiki is accurate on this matter, however.

This is easy to verify in logs, and I've checked myself and it does appear to actually be doing the damage.

The incorrect code in Bronya.py:

# Incorrect code; note that self.e4 trigger is always set to true at start and reset each of Bronya's turns
if AtkType.BSC in turn.atkType and turn.moveName not in bonusDMG and self.e4Trigger and result.enemiesHit:
    self.e4Trigger = False
    e5Mul = 1.1 if self.eidolon >= 5 else 1.0
    # note that the err gain here is 0, while the wiki claims it's 5
    tl.append(Turn(self.name, self.role, result.enemiesHit[0].enemyID, Targeting.SINGLE, [AtkType.FUA, AtkType.BSC], [self.element], [0.8 * e5Mul, 0], [10, 0], 0, self.scaling, 0, "BronyaFUA"))

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions