Conversation
agg23
reviewed
Sep 10, 2026
agg23
left a comment
agg23
left a comment
Member
There was a problem hiding this comment.
My immediate reaction to this was that geolocating using surrounding WiFi networks was against my privacy stance and goals for the project, but after more thought I think it's probably fine.
The actual HTTP client should be in server-rs/src/external. Everything looks roughly correct
agg23
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses beaconDB to implement GPS fallback for the pin.
beaconDB is a public-domain wireless geolocation database. It's a replacement for the now-defunct Mozilla Location Service.
Most of the code in this PR was generated with Codex (using
gpt-6-astra), but has been manually reviewed.