Extend default SIG{TERM,KILL} window to allow Pelican conn draining - #7
Extend default SIG{TERM,KILL} window to allow Pelican conn draining#7brianhlin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Helm chart’s Deployment behavior to give the Pelican cache more time to gracefully shut down (drain connections) before Kubernetes escalates from SIGTERM to SIGKILL.
Changes:
- Set
terminationGracePeriodSeconds: 75in the pod spec to allow connection draining. - Bump chart version from
0.2.4to0.2.5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| templates/deployment.yaml | Extends pod termination grace period to allow Pelican/XRootD shutdown/drain time. |
| Chart.yaml | Increments chart version to reflect the behavioral change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Allow Pelican to drain connections | ||
| # Default Xrootd.ShutdownTimeout of 60s + 15s buffer | ||
| terminationGracePeriodSeconds: 75 |
There was a problem hiding this comment.
Can you do math in Helm templating??
EDIT: I guess we could just use what they specify and otherwise default to 75s
There was a problem hiding this comment.
You can do math with the add function, e.g. {{ add .Values.foo 15 }}
https://helm.sh/docs/chart_template_guide/function_list/#math-functions
|
Yeah, I'd say do something like the following instead: to values.yaml add, under cacheConfig: to the spec in deployment.yaml: to configmap-pelican.yaml: (untested) Also be sure to update README.md. |
As suggested by @h2zh