Fix inefficient spatial covariance calculation in emulator and add tests#3969
Open
man080107 wants to merge 1 commit into
Open
Fix inefficient spatial covariance calculation in emulator and add tests#3969man080107 wants to merge 1 commit into
man080107 wants to merge 1 commit into
Conversation
mdietze
approved these changes
May 1, 2026
| expect_true(is.matrix(res)) | ||
| expect_equal(dim(res), c(2, 2)) | ||
|
|
||
| expected <- tau * exp(-psi * d) |
Member
There was a problem hiding this comment.
Having the expected value come from the exact same calculation isn't a strong test that the calculation is correct. Would be better to store what the expected cov matrix should be.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Review Time Estimate
Types of changes
Checklist: