Skip to content

data prep and post bias correction for NEE and LE#3934

Open
Amedieus wants to merge 1 commit into
PecanProject:developfrom
Amedieus:data_prep-and-bcm
Open

data prep and post bias correction for NEE and LE#3934
Amedieus wants to merge 1 commit into
PecanProject:developfrom
Amedieus:data_prep-and-bcm

Conversation

@Amedieus
Copy link
Copy Markdown

bias correct the results from SDA output of NEE and LE

@@ -0,0 +1,747 @@
## Load packages
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file just contains functions, which I think would be better migrated to the R folder instead of the inst folder, in which case you'll need to drop the library calls, make namespaces explicit, and compile + commit the Rd man files for each function

@@ -0,0 +1,633 @@
## Load packages
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same points about migrating to R folder. For both files, I'd @export the minimal set of functions (I'm assuming many of these functions are exclusively being called by other functions internally). Since there's no "master script" here that runs your actual debiasing, I'd either add that (either as an inst script or uncompiled vignette) or provide an unrun example for the few high-level functions that are being exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants