Refactor SIPNET to separate version logic from availability checks#3862
Open
Thomas-Sedhom wants to merge 1 commit into
Open
Conversation
infotroph
reviewed
May 19, 2026
Member
infotroph
left a comment
There was a problem hiding this comment.
@Thomas-Sedhom Thanks for opening this and my apologies that it waited so long for review.
- Are you interested in continuing work on this? If so I'm happy to advise more (and faster!), if not I'll push the updates needed to get it merged; either way you'll have author credit on the changes to date.
- In the time this was waiting, model2netcdf.SIPNET has changed to ignore the revision string entirely and clarify that behavior depends only on the column names in sipnet.out, so I'm leaning toward dropping all model2netcdf changes from this PR to focus it on write.config. Does that make sense to you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This keeps version driven behavior in one place and avoids interleaving it with presence checks for optional inputs or output columns, improving readability and maintainability.
Motivation and Context
Solve: #3854
Review Time Estimate
Types of changes
Checklist: