Default review mode true; CLI injects publish form#105
Merged
Conversation
`\ReviewModetrue` was an opt-in toggle authors flipped on while reviewing a draft locally. The hazard: the toggle lived in the .tex source itself, so a forgotten line on a finished handout shipped the review form to the website (it just did, on angle-basics-1.sk.tex). The local workflow is always review; only the Handouts CLI produces the publish form. So invert the default: the template now starts `\ReviewMode` true, and the CLI defines a `\PUBLISH` sentinel on the pdfcsplain command line before \input — the template flips itself off when it sees the sentinel. Manual pdfcsplain compiles keep producing the inline-solutions PDF; the CLI is the single gate that produces the publish PDF.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\ReviewModedefault in_template.texfromfalsetotrue, so manualpdfcsplaincompiles always render the inline-solutions review form without per-file opt-in.BuildCommand.CompileTexFilenow defines\PUBLISHon the pdfcsplain command line before\input; the template flips\ReviewModeoff when it sees the sentinel, so the CLI is the single gate that produces the publish PDF.\ReviewModetrueline fromangle-basics-1.sk.tex— the override that accidentally shipped tomain. Grep confirmed no other handouts touch the macro.