52: Email send script by isabellalam12 · Pull Request #16 · Patina-Network/patchats

isabellalam12 · 2026-05-30T02:52:47Z

No description provided.

graphite-app · 2026-05-30T02:55:03Z

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (05/30/26)

2 reviewers were added to this PR based on Henry Chen's automation.

graphite-app · 2026-05-30T02:57:38Z

+        const data = fs.readFileSync(csv, "utf-8");
+
+        const lines = data.split("\n").map(line => line.trim()).filter(line => line.length > 0);
+        const csvArray = lines.map(line => line.split(",").map(cell => cell.trim()));


Critical CSV parsing bug. Using split(",") will incorrectly parse CSV fields that contain commas within quotes. The test data includes fields like "Tahmid is a senior at Hunter College & has been interning at Integral Ad Science for close to a year now, as well as running various software projects for Patina. Tahmid likes to eat good food :)" which contains commas. This will cause:

Incorrect column counts

Misaligned field mappings

Runtime errors when accessing row[headerIndex['Email']] (line 43) due to wrong indices

Fix: Use a proper CSV parsing library:

import { parse } from 'csv-parse/sync'; // Then replace lines 29-30 with: const csvArray = parse(data, { skip_empty_lines: true, trim: true });

Suggested change

const csvArray = lines.map(line => line.split(",").map(cell => cell.trim()));

const csvArray = parse(data, {

skip_empty_lines: true,

trim: true

});

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

isabellalam12 · 2026-05-30T03:01:25Z

52: Email send script #16 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2026-05-30T03:03:53Z

+            row[headerIndex['Topics']],
+            row[headerIndex['Anything']]
+        );
+        usersMap[email] =  user;


Critical Bug: Incorrect Map usage

Using bracket notation on a Map object doesn't add entries to the Map. This creates a regular object property instead, so the Map will remain empty and subsequent lookups will fail.

// Wrong: usersMap[email] = user; // Correct: usersMap.set(email, user);

Suggested change

usersMap[email] = user;

usersMap.set(email, user);

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-05-30T03:03:54Z

+            const pair = new Pair(
+                row[0], //fullNameA
+                row[1], //fullNameB
+                row[2], //emailA
+                row[3]  //emailB
+            );


Critical Bug: CSV column order mismatch

The pairings CSV has columns in order fullNameA,emailA,fullNameB,emailB but the code assumes fullNameA,fullNameB,emailA,emailB. This causes names and emails to be swapped incorrectly:

row[1] (emailA) is assigned to fullNameB

row[2] (fullNameB) is assigned to emailA

// Current (wrong): const pair = new Pair( row[0], //fullNameA row[1], //fullNameB - actually emailA in CSV row[2], //emailA - actually fullNameB in CSV row[3] //emailB ); // Should be: const pair = new Pair( row[0], //fullNameA row[2], //fullNameB row[1], //emailA row[3] //emailB );

Suggested change

const pair = new Pair(

row[0], //fullNameA

row[1], //fullNameB

row[2], //emailA

row[3] //emailB

);

const pair = new Pair(

row[0], //fullNameA

row[2], //fullNameB

row[1], //emailA

row[3] //emailB

);

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

Yeah It shouldn't be row 0 2 1 3 lmao

arklian · 2026-06-02T15:01:48Z

We want the email functionality on the backend side in Java.

arklian · 2026-06-02T15:16:41Z

Usually, the naming convention for pure JS/TS files is all lowercase.

React components in tsx files are the ones that should be in PascalCase.

Also almost all the code should be in TS or TSX, not JS.

arklian · 2026-06-02T15:17:59Z

+            pairings.push(pair);
+
+        }
+   }catch (err){    


I feel like the autoformatter isn't working. Yeah the CI test is failing.

We should be adding prettier --write to the git precommit hooks so that we don't have to remember to run it.

arklian · 2026-06-02T15:19:13Z

Casually leaking Tahmid's and Andrew's emails 😅

arklian · 2026-06-02T15:20:04Z

+            const pair = new Pair(
+                row[0], //fullNameA
+                row[1], //fullNameB
+                row[2], //emailA
+                row[3]  //emailB
+            );


Yeah It shouldn't be row 0 2 1 3 lmao

arklian · 2026-06-02T15:29:22Z

+const SENDER_NAME = "Patina Network"
+const SENDER_EMAIL = "bella.patinanetwork@gmail.com"
+const APP_PASSWORD = ""
+const USERS_FILE = "js/src/app/user/admin/emails/users-test.csv"


We'll need to move this from being read as a file to a user input in the future.

arklian · 2026-06-02T15:54:04Z

+const PAIRINGS_FILE = "js/src/app/user/admin/emails/pairings-test.csv"
+
+//classes 
+class User {


These should likely be interfaces instead of classes. Classes should pretty rarely be used in general, especially not for pure data objects.

arklian · 2026-06-02T15:55:50Z

+    return requiredHeaders.every(header => headers.includes(header)); //returns true if all requiredheaders are present, false otherwise
+}
+
+function splitCSVLine(line){ //split lines w/ commas as deliminators (manually implmented to handle commas within quotes)


We probably should be using a library to parse the CSVs. Isn't commas within quotes part of the usual CSV standard?

…objects to backend

graphite-app · 2026-06-04T02:18:30Z

+  await fetch("/api/emails/send-users", {
+        method: "POST",
+        headers: { "Content-Type": "application/json" },
+        body: JSON.stringify(userMap)
+      });


Serializing a Map with JSON.stringify(userMap) will produce an empty object {}. Map objects are not directly JSON-serializable and will result in {} being sent to the API.

Fix: Convert the Map to an object or array before stringifying:

await fetch("/api/emails/send-users", { method: "POST", headers: { "Content-Type": "application/json" }, body: JSON.stringify(Object.fromEntries(userMap)) // OR: body: JSON.stringify(Array.from(userMap.entries())) });

Suggested change

await fetch("/api/emails/send-users", {

method: "POST",

headers: { "Content-Type": "application/json" },

body: JSON.stringify(userMap)

});

await fetch("/api/emails/send-users", {

method: "POST",

headers: { "Content-Type": "application/json" },

body: JSON.stringify(Object.fromEntries(userMap))

});

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-06-04T02:18:31Z

+parseUserFile(USER_FILE);
+parsePairingFile(PAIR_FILE);


Calling async functions at module top-level without await will result in unhandled promise rejections if these functions fail. The functions will execute but errors won't be caught, and the module will continue loading even if the operations fail.

Fix: Either wrap in an async IIFE with error handling or use top-level await:

(async () => { try { await parseUserFile(USER_FILE); await parsePairingFile(PAIR_FILE); } catch (error) { console.error('Failed to parse files:', error); } })();

Suggested change

parseUserFile(USER_FILE);

parsePairingFile(PAIR_FILE);

(async () => {

try {

await parseUserFile(USER_FILE);

await parsePairingFile(PAIR_FILE);

} catch (error) {

console.error('Failed to parse files:', error);

}

})();

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-06-04T02:28:23Z

+  const results = Papa.parse(userFile, config);
+  const userMap = new Map<string, User>();
+
+  for (const userData of results.data) {
+    const user: User = {
+      name: userData.Name,
+      email: userData.Email,
+      intro: userData.Intro, 
+      linkedin: userData.LinkedIn,
+      industry: userData.Industry,
+      preferences: userData.Preferences,
+      topics: userData.Topics,
+      anything: userData.Anything
+    };
+
+    userMap.set(user.email, user);


Critical: No error checking or type safety on parsed data

Papa.parse() returns an object with errors array that is not checked. Additionally, userData properties are accessed without validation, which will create User objects with undefined values if column names don't match exactly.

const results = Papa.parse(userFile, config); // results.errors is never checked! for (const userData of results.data) { // userData.Name could be undefined if CSV column is named differently const user: User = { name: userData.Name, // No validation!

Add error handling and validate that required columns exist before accessing properties.

Suggested change

const results = Papa.parse(userFile, config);

const userMap = new Map<string, User>();

for (const userData of results.data) {

const user: User = {

name: userData.Name,

email: userData.Email,

intro: userData.Intro,

linkedin: userData.LinkedIn,

industry: userData.Industry,

preferences: userData.Preferences,

topics: userData.Topics,

anything: userData.Anything

};

userMap.set(user.email, user);

const results = Papa.parse(userFile, config);

if (results.errors && results.errors.length > 0) {

console.error("CSV parsing errors:", results.errors);

throw new Error(`Failed to parse CSV: ${results.errors.map(e => e.message).join(", ")}`);

}

const userMap = new Map<string, User>();

for (const userData of results.data) {

if (!userData.Email || !userData.Name) {

console.warn("Skipping row with missing required fields:", userData);

continue;

}

const user: User = {

name: userData.Name,

email: userData.Email,

intro: userData.Intro,

linkedin: userData.LinkedIn,

industry: userData.Industry,

preferences: userData.Preferences,

topics: userData.Topics,

anything: userData.Anything

};

userMap.set(user.email, user);

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-06-04T19:12:22Z

+  await fetch("/api/emails/send-pairings", {
+        method: "POST",
+        headers: { "Content-Type": "application/json" },
+        body: JSON.stringify(pairings)
+      });


The fetch call has no error handling. If the API request fails (network error, 4xx/5xx status), the function will silently continue and return the pairings without any indication of failure. This could lead to the application appearing to work while emails are never sent.

const response = await fetch("/api/emails/send-pairings", { method: "POST", headers: { "Content-Type": "application/json" }, body: JSON.stringify(pairings) }); if (!response.ok) { throw new Error(`Failed to send pairings: ${response.statusText}`); }

Suggested change

await fetch("/api/emails/send-pairings", {

method: "POST",

headers: { "Content-Type": "application/json" },

body: JSON.stringify(pairings)

});

const response = await fetch("/api/emails/send-pairings", {

method: "POST",

headers: { "Content-Type": "application/json" },

body: JSON.stringify(pairings)

});

if (!response.ok) {

throw new Error(`Failed to send pairings: ${response.statusText}`);

}

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-06-04T19:12:23Z

+
+        Element supportText = doc.getElementById("input-supportEmail-innerText");
+        assertNotNull(supportText, "Missing element: input-supportEmail-innerText");
+        assertEquals("codebloom@patinanetwork.org", supportText.text(), "supportEmail text not set");


Test expects "codebloom@patinanetwork.org" but the input on line 20 is "patchats@patinanetwork.org". Additionally, the implementation on line 28 of ReactEmailTemplaterImpl.java prepends "mailto:" to the supportEmail, so the actual text would be "mailto:patchats@patinanetwork.org". This test will fail.

assertEquals("mailto:" + supportEmail, supportText.text(), "supportEmail text not set");

Suggested change

assertEquals("codebloom@patinanetwork.org", supportText.text(), "supportEmail text not set");

assertEquals("mailto:" + supportEmail, supportText.text(), "supportEmail text not set");

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

sonarqubecloud · 2026-06-08T18:58:10Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

isabellalam12 added 3 commits May 29, 2026 18:51

52: Wrote code to parse the users.csv

daa11e5

52: added function to split lines and handle commas within quotation

c55af98

52: finished csv parse code for pairings

5db0332

isabellalam12 requested a review from a team as a code owner May 30, 2026 02:52

graphite-app Bot requested review from Arshadul-Monir and arklian May 30, 2026 02:53

graphite-app Bot reviewed May 30, 2026

View reviewed changes

52: fixed logic error in pair object and map syntax

6d7d8d3

arklian requested changes Jun 2, 2026

View reviewed changes

isabellalam12 added 2 commits June 3, 2026 09:09

52: Updated parse implementation to use TS and PapaParse api

fefb743

52: moved interfaces out of function and added POST request for JSON …

40600c6

…objects to backend

graphite-app Bot reviewed Jun 4, 2026

View reviewed changes

52: Converted userMap to an object before stringifying

cfac79a

graphite-app Bot reviewed Jun 4, 2026

View reviewed changes

52: Starting backend email sending

985427c

graphite-app Bot reviewed Jun 4, 2026

View reviewed changes

52: email backend set up

1b3dffd

isabellalam12 requested a review from arklian June 8, 2026 18:48

52: removed email folder

6ceb451

-        const csvArray = lines.map(line => line.split(",").map(cell => cell.trim()));
+        const csvArray = parse(data, {
+          skip_empty_lines: true,
+          trim: true
+        });

-parseUserFile(USER_FILE);
-parsePairingFile(PAIR_FILE);
+(async () => {
+  try {
+    await parseUserFile(USER_FILE);
+    await parsePairingFile(PAIR_FILE);
+  } catch (error) {
+    console.error('Failed to parse files:', error);
+  }
+})();

	assertEquals("codebloom@patinanetwork.org", supportText.text(), "supportEmail text not set");
	assertEquals("mailto:" + supportEmail, supportText.text(), "supportEmail text not set");

Conversation

isabellalam12 commented May 30, 2026

Uh oh!

graphite-app Bot commented May 30, 2026

Graphite Automations

Uh oh!

graphite-app Bot May 30, 2026

Choose a reason for hiding this comment

Uh oh!

isabellalam12 commented May 30, 2026

Uh oh!

graphite-app Bot May 30, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot May 30, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 8, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants