Fix three open bugs - #125
Merged
Merged
Conversation
- Fixes copy and paste issues in titles. - Add missing configuration options to the printConfiguration method.
- parseAllowedIPAddresses used logger.Fatal on an invalid entry, which calls os.Exit and would kill the whole Traefik process on a config typo. Additionally it ran before the logger was pointed at stdout, so the process died without any message. It now returns an error that New propagates, matching how invalid excludedPathPatterns are handled. - Reverse-proxy mode panicked with "slice bounds out of range" when a request carried neither X-Forwarded-For nor X-Real-IP, because requestIPAddresses[:1] had no emptiness guard. Such requests are now denied with 403, consistent with the unparsable-IP path. - The cache-TTL refresh path only honored ignoreApiFailures, silently dropping the ignoreApiTimeout fail-open policy that the cache-miss path applied. An IP whose entry had just expired was denied on an API timeout the operator had configured to be ignored. Both paths now share one handleLookupError helper implementing the full policy.
PascalMinder
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseAllowedIPAddresses used logger.Fatal on an invalid entry, which
calls os.Exit and would kill the whole Traefik process on a config
typo. Additionally it ran before the logger was pointed at stdout, so
the process died without any message. It now returns an error that New
propagates, matching how invalid excludedPathPatterns are handled.
Reverse-proxy mode panicked with "slice bounds out of range" when a
request carried neither X-Forwarded-For nor X-Real-IP, because
requestIPAddresses[:1] had no emptiness guard. Such requests are now
denied with 403, consistent with the unparsable-IP path.
The cache-TTL refresh path only honored ignoreApiFailures, silently
dropping the ignoreApiTimeout fail-open policy that the cache-miss
path applied. An IP whose entry had just expired was denied on an API
timeout the operator had configured to be ignored. Both paths now
share one handleLookupError helper implementing the full policy.
also fix documentation issues regarding copy and paste issues.