You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE: This does not require a re-deploy of SellMembershipAuthority. It behaves the same way but updates some comments and outdated and unnecessary logic when returning contribution amount to emit.
Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").
💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.
This just went through an audit and changes provide no material benefits. I don't think this should be prioritized now.
I actually didn't imagine we'd deploy this until the next significant change involving SellMembershipAuthority so yeah I kinda agree. I am concerned though that not updating in our remote repo will confuse people reading that code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This does not require a re-deploy of
SellMembershipAuthority. It behaves the same way but updates some comments and outdated and unnecessary logic when returning contribution amount to emit.