[Backport to 6.8] Fix for management utility hostname fields validation rejects hyphens and allows invalid characters #5244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fix hostname field input blocking in ServiceControl Management Utility **Fixes #5190** ## Problem The hostname fields in the ServiceControl Management Utility (SCMU) were blocking valid dash (`-`) characters from being typed, while allowing invalid characters like `/[]|`. This was caused by CheckBox controls intercepting keystrokes for nested TextBox controls in the add instance views. Users reported that typing `-` would not work but typing any of `/[]|` does work. The only workaround was to paste the dash character from the clipboard. ## Root Cause The issue occurred because: 1. TextBox controls for hostname input were nested inside CheckBox controls in the XAML layout 2. WPF CheckBox controls intercept certain keystrokes (including dashes) for their nested content 3. This prevented users from typing dashes directly into hostname fields, requiring copy/paste workarounds ## Solution Restructured the UI layout in the add instance views to separate CheckBox and Expander controls using a Grid-based horizontal layout. ### Before: ```xaml <CheckBox IsChecked="{Binding InstallErrorInstance}"> <Expander Header="ServiceControl"> <!-- TextBox controls nested inside CheckBox --> <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" /> </Expander> </CheckBox> ``` ### After: ```xaml <Grid> <Grid.ColumnDefinitions> <ColumnDefinition Width="Auto"/> <ColumnDefinition Width="*"/> </Grid.ColumnDefinitions> <CheckBox Grid.Column="0" IsChecked="{Binding InstallErrorInstance}" VerticalAlignment="Top" Margin="0,8,8,5"/> <Expander Grid.Column="1" Header="ServiceControl" IsEnabled="{Binding InstallErrorInstance}" Margin="0,5,0,5"> <!-- TextBox controls no longer nested in CheckBox --> <StackPanel Visibility="{Binding InstallErrorInstance, Converter={StaticResource boolToVis}}"> <controls:FormTextBox Header="HOST NAME" Text="{Binding ErrorHostName}" /> </StackPanel> </Expander> </Grid> ``` Co-authored-by: Christian <christian.quiros+github@gmamil.com>
# Fix hostname validation in SCMU ## Summary This PR completes the fix for issue #5190 by adding proper hostname validation to ServiceControl.Config. While PR #5238 partially addressed the issue by allowing dashes in hostnames, it didn't implement comprehensive hostname validation, leaving users able to enter invalid hostnames that would cause configuration issues. ## Background **Original Issue**: #5190 reported that ServiceControl.Config was not properly validating hostname fields, allowing users to enter invalid values that would cause runtime failures. **Previous Fix**: PR #5238 addressed part of the problem by allowing dashes in hostnames, but the validation was still incomplete and didn't prevent other invalid hostname formats. **This Fix**: Implements comprehensive RFC-compliant hostname validation using .NET's built-in `Uri.CheckHostName()` method. ## Validation Behavior The new validation accepts: - ✅ Valid DNS hostnames (server01, myhost.domain.com) - ✅ localhost - ✅ Hostnames with dashes (server-01, my-host.domain.com) - *previously fixed by PR #5238* * test case for IPV6 * fixing broken implementation for ips * adding missing test cases * Update src/ServiceControl.Config.Tests/Validation/EditAuditInstanceValidationTests.cs Co-authored-by: Nick Gallegos <nick.gallegos@particular.net>
DharmishthaVPatel
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to release-6.8 fix for: