Repository navigation
feat(desktop): the assistant makes a screw lid for a round container - #324
Merged
Merged
Conversation
partbuddy_mechanism takes kind lid. It coils a thread with 45° flanks onto the neck and makes the lid with the matching thread, flutes to grip and its top as print face. The two mesh as built and print without support. Print faces set by a mechanism or a template are now kept for the plate view, so the lid and the stop lie there as they will print. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of the standards the product owner chose on 2026-11-11: a screw lid, which improvised is nearly always too tight or too loose.
lidSteps/lidThread/lidSkirt/lidProblem(mechanisms.ts): a thread with flat crests and roots and flanks at 45° (prints without support on the standing neck and in the lid lying on its top), coiled onto the neck withsolid.coilover a drawn section. Pitch 3, 4 or 5 mm and depth 1.1, 1.2 or 1.5 mm by the neck's diameter (after the neck finishes of bottles and usual printed jars), 1.75 turns of engagement, 1 to 3 starts. The lid is made by the mechanism: a cap that stops with its inner top on the rim, the same thread half a pitch lower and the gap further out, so the two mesh as built; flutes to grip; the last 0.6 mm of its top are a cone for the bed.partbuddy_mechanism {kind: lid}: the container, the name the lid shall have, the centre of the rim and the neck's outer diameter;starts,gap(three quarters of the nozzle, at least 0.3 mm).tois no longer required by the schema. A name that is taken is refused; a thread that does not touch the neck is taken back with what the neck must be.print-faces.json. The lid's face is now kept and sent to the window (design:print-faces-changed), and so are the print faces of a template (the stop of the adjustable stop lay as designed on the plate until now).printFaceNamewaits for the engine after a project switch and logs when a face is not kept.solid.thread. Its trapezoidal form has 15° flanks, which overhang in print, and the phase of two threads cannot be set, so they overlapped as built. Found on the way: 0.40.0-rc.4 refuses to chamfer the top edge of a plain cylinder from about 60 mm of diameter, hence the cone.Checked: eslint, typecheck, all unit tests; against SolidCraft 0.40.0-rc.4 a new contract test (jar and lid through the fake assistant: 2 bodies, no overlap, no failed feature; on the plate the lid lies on its top), the template test (the stop lies on its top on the plate) and the print face, screw joint and closure tests. With
solidcraft-cli: necks of 16, 40, 60, 100 and 200 mm with 1 to 3 starts build without interference. Not printed; the clearance is the middle of a disputed range (0.2 to 0.6 mm in the sources).🤖 Generated with Claude Code