test: add test for upgrade with new_version == current_version rejecting - #291
Merged
nonsobethel0-dev merged 2 commits intoJul 30, 2026
Conversation
|
@Adedayo-Data Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces test coverage for the
upgradefunction constraint in thegovernance-daocontract. Specifically, it verifies that any attempt to upgrade the contract WASM where thenew_versionis equal to (or lower than) thecurrent_versionis rejected with aVersionNotNewererror.Changes
test_upgrade_rejects_same_versionincontracts/governance-dao/src/test.rs.create_proposalinsidetest_proposal_expires_after_voting_periodto restore crate compilation.closes #210