Skip to content

Clarify review selection and simplify connection status - #108

Merged
cu1ch3n merged 3 commits into
mainfrom
fix/note-review-state
Nov 9, 2026
Merged

cu1ch3n merged 3 commits into
mainfrom
fix/note-review-state

Conversation

@cu1ch3n

@cu1ch3n cu1ch3n commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

The note preview drawer did not make its relationship to the selected PDF change clear. Shared note badges also wrapped into tall stacks, and normal agent startup appeared as a large warning card.

  • Highlight the exact source change with an accent border, tinted header and emphasized change number. The preview toolbar uses the same accent; related fragments have a quieter marker. The annotation counter explicitly says “Note”. Opening a PDF note badge keeps that exact change in view, and navigation scrolls only the PDF pane. No extra linked-change row is needed.
  • Group note numbers on one compact row with a shared icon while keeping each note accessible separately.
  • Show normal agent connection as a subtle spinner and text. Keep connection errors, details and reconnect available; distinguish sign-in requirements from connecting.

Validation: application and engine builds, TypeScript checks, app locale checks, 16 note-linking/options tests, and extended note-results and task-model browser flows. Browser checks cover historical/current rounds, exact navigation among multiple linked changes, matching selection accents, narrow layouts, grouped badges, connection progress, errors, sign-in and recovery. Light, dark and mobile screenshots reviewed.

@cu1ch3n cu1ch3n left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review/fix completed:

  • Verified that the drawer labels use the same zero-based stop + 1 numbering as the PDF viewer, and only list changes from the round whose comparison is displayed.
  • Fixed multi-change navigation so both drawer links and PDF note badges keep the exact clicked change instead of returning to the note’s first change.
  • Fixed scrolling to stay inside the PDF pane; focused headers receive a matching highlight. Adjusted the browser fixture to use the real review scroll container and verified the destination header stays above the drawer.
  • Rechecked historical/current rounds, source/PDF option switches, remembered choices, and 390px layouts. Switching previews and following links perform no option writes.

Validation passed: application/engine builds, root/desktop TypeScript checks, all app locale checks, 16 note linking/options tests, and the extended note-results browser flow. Desktop and mobile screenshots inspected. No outstanding findings in this change.

@cu1ch3n
cu1ch3n marked this pull request as ready for review November 9, 2026 06:17
@cu1ch3n cu1ch3n changed the title Identify note previews by their linked change numbers Clarify review links and simplify connection status Nov 9, 2026

@cu1ch3n cu1ch3n left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review of the visual changes at a332054:

  • Shared note badges now use one decorative icon and separate, labeled number buttons on one row. Keyboard focus and touch hit areas are preserved; long groups scroll rather than wrap.
  • Connection progress has a neutral background and spinner. Missing agents/errors still show a warning, expandable details and Reconnect. A connected agent needing authentication says “Sign-in required”.
  • Verified the updated browser flows, including three annotations sharing a change, exact change navigation, connection/error/authenticated transitions, and 390px layouts. Screenshots inspected; application build, TypeScript and locale checks pass.

No outstanding review findings. GitHub CI is running on the final head. The earlier Linux packaging failure was an HTTP 504 while downloading Electron dependencies.

@cu1ch3n cu1ch3n changed the title Clarify review links and simplify connection status Clarify review selection and simplify connection status Nov 9, 2026

@cu1ch3n cu1ch3n left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the final selection changes at bdf2951:

  • Removed the additional linked-change row and its unused translations. Selection is communicated directly by the source change and preview toolbar.
  • The focused change alone gets the strong border and tinted header; other fragments linked to the same annotation retain a quieter marker. Clicking a badge on a later fragment preserves that exact target.
  • Browser regression tests pass for exact fragment selection, synchronized accent colors, header visibility above the drawer, shared badges, closing/reopening and narrow layouts. Inspected light/dark screenshots. Build, locale checks and diff checks pass.

No outstanding findings from this review. Awaiting CI on the updated head before merging.

@cu1ch3n
cu1ch3n merged commit 9dcf5ca into main Nov 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant