Repository navigation
Fix bundled note decisions around LaTeX environment edits - #107
Conversation
|
Reviewed commit 8c445c1. No blocking code findings after checking both sides of environment insertion/removal/rename, nested display boundaries, comment/literal masking, quote ambiguity, and the acceptance/option paths. The regression suite verifies every subset of independent changes, including reversion, and a real multi-chapter PDF check confirms distinct alternative content and a focused drawer. Local desktop activation of the update layer also passes with the installed Node 24 runtime. The affected saved round predates this fix. Its existing decisions must stay intact; the local recovery is creating a new comparison of only the pending proposal and retains paragraph boundaries for the author's already prepared options. Node 24 CI and CodeQL pass. macOS and Windows packaging both hit an external HTTP 504 while downloading build dependencies; those jobs will be retried after the current workflow finishes. |
|
Follow-up review found and fixed a second issue in 72dd53a: independent notes could still share a large PDF crop, so an alternative initially displayed unrelated leading text. The drawer now uses attributed marks to select and crop the relevant strips, preserves complete intersecting lines, and retains the legacy fallback when attribution is absent. A browser fixture now places the note far down a shared strip and checks the visible crop geometry as well as option switching. Re-review: no further blocking code findings. All nine existing alternatives for the affected notes have now been compiled and checked against their intended units, with distinct content and focused PDF crops. The installed desktop is running 0.9.4-dev.72dd53a, and its native interface has been checked. The original review actions and manuscript diff remain byte-for-byte unchanged; recovery created a separate round for pending edits and kept the existing choices. Latest Node 24, Windows desktop, Linux desktop and CodeQL checks pass. The macOS packaging failure is again an upstream dependency download returning HTTP 504; it will be retried after the current run finishes. No failing checks will be bypassed. |
Editing a display formula or removing a list could merge every change in its LaTeX file into one review unit. Independent notes then shared badges, accepting one applied unrelated edits, and alternatives all opened at the same earlier passage.
Group edits only within the environment whose delimiters change, scanning both revisions and ignoring comments/literal examples. Balanced nested displays remain atomic without absorbing surrounding prose. Resolve repeated short PDF quotes using original manuscript lines; ambiguous and older-review quotes still fail closed.
A second review using the affected document found that independent units can still share a large PDF group. Alternative previews now use per-unit marks to select the relevant strips and crop to nearby complete lines, including the focused units in source view. Older comparisons without attribution retain their existing context. The main review remains intact.
Validation:
Existing published rounds retain their recorded units and decisions and need a fresh comparison to use the new segmentation. Alternatives that edit outside a note's separated units remain rejected by the existing scope checks.