Skip to content

Fix PlayerLinksSendEvent not firing when no global links are configured #14026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noctiro wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix PlayerLinksSendEvent not firing when no global links are configured #14026

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba74d31
Always fire PlayerLinksSendEvent regardless of global links
noctiro Jul 3, 2026
499ba78
Move end comment one line up
Warriorrrr Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions ...hes/sources/net/minecraft/server/network/ServerConfigurationPacketListenerImpl.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,14 @@
+ new io.papermc.paper.event.connection.configuration.PlayerConnectionInitialConfigureEvent(this.paperConnection).callEvent(); // Paper
this.send(new ClientboundCustomPayloadPacket(new BrandPayload(this.server.getServerModName())));
ServerLinks serverLinks = this.server.serverLinks();
if (!serverLinks.isEmpty()) {
- if (!serverLinks.isEmpty()) {
- this.send(new ClientboundServerLinksPacket(serverLinks.untrust()));
+ // Paper start
+ org.bukkit.craftbukkit.CraftServerLinks links = new org.bukkit.craftbukkit.CraftServerLinks(serverLinks);
+ new org.bukkit.event.player.PlayerLinksSendEvent(this.paperConnection, links).callEvent();
+ // Paper start
+ org.bukkit.craftbukkit.CraftServerLinks links = new org.bukkit.craftbukkit.CraftServerLinks(serverLinks);
+ new org.bukkit.event.player.PlayerLinksSendEvent(this.paperConnection, links).callEvent();
+ if (!links.getServerLinks().isEmpty()) {
+ this.send(new ClientboundServerLinksPacket(links.getServerLinks().untrust()));
+ // Paper end
+ // Paper end
}

LayeredRegistryAccess<RegistryLayer> registries = this.server.registries();
Expand Down
Loading