Skip to content

Remove WorkloadIdentity from non-interactive credential chain#207

Merged
PalmEmanuel merged 3 commits into
copilot/consolidate-auth-flows-listfrom
copilot/remove-workload-identity-credential
Mar 28, 2026
Merged

Remove WorkloadIdentity from non-interactive credential chain#207
PalmEmanuel merged 3 commits into
copilot/consolidate-auth-flows-listfrom
copilot/remove-workload-identity-credential

Conversation

Copilot AI commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

K8s is not a target environment for AzAuth today, so the WorkloadIdentity addition to the non-interactive credential chain (added in #206) is being removed. The explicit -WorkloadIdentity parameter set that existed prior to #206 is preserved.

Removed

  • WorkloadIdentity option from -CredentialPrecedence (ValidateSet + default chain)
  • WorkloadIdentity case from the non-interactive credential chain switch (TokenManager.NonInteractive.cs)
  • WorkloadIdentity URL from GetCredentialDocumentationUrl
  • Workload identity entry from the non-interactive chain description in docs
Original prompt

Pull request: https://github.com/PalmEmanuel/AzAuth/pull/206/files

I think I wanna remove the WorkloadIdentity credential that was added because k8s isn't an environment that AzAuth is likely to run in (today)


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

…ain, tests, docs)

Agent-Logs-Url: https://github.com/PalmEmanuel/AzAuth/sessions/e86bc179-5996-4037-85a9-3bbccd08416e

Co-authored-by: PalmEmanuel <3384251+PalmEmanuel@users.noreply.github.com>
@PalmEmanuel
PalmEmanuel marked this pull request as ready for review March 28, 2026 14:49
Copilot AI changed the title [WIP] Remove WorkloadIdentity credential from AzAuth Remove WorkloadIdentity credential Mar 28, 2026
Copilot AI requested a review from PalmEmanuel March 28, 2026 14:50
@PalmEmanuel

Copy link
Copy Markdown
Owner

@copilot No you removed too much, only remove the WorkloadIdentity related things that were implemented in the other (still not merged) PR.

…e explicit parameter set

Agent-Logs-Url: https://github.com/PalmEmanuel/AzAuth/sessions/9c68a216-fa3e-40c3-ac12-94538d419043

Co-authored-by: PalmEmanuel <3384251+PalmEmanuel@users.noreply.github.com>

Copilot AI commented Mar 28, 2026

Copy link
Copy Markdown
Contributor Author

@copilot No you removed too much, only remove the WorkloadIdentity related things that were implemented in the other (still not merged) PR.

Fixed in 2a4be74. The scope of removals is now limited to only what the base branch PR added for WorkloadIdentity in the non-interactive chain:

  • Removed WorkloadIdentity from CredentialPrecedence ValidateSet and default value
  • Removed WorkloadIdentityCredential case from TokenManager.NonInteractive.cs
  • Removed WorkloadIdentity URL from GetCredentialDocumentationUrl
  • Removed workload identity from the non-interactive chain description in docs

The -WorkloadIdentity/-ExternalToken parameter set, TokenManager.WorkloadIdentity.cs, tests, module tags, and all parameter docs that were already in main are preserved.

Copilot AI changed the title Remove WorkloadIdentity credential Remove WorkloadIdentity from non-interactive credential chain Mar 28, 2026
@PalmEmanuel PalmEmanuel added the bug Something isn't working label Mar 28, 2026
@PalmEmanuel
PalmEmanuel merged commit cb689aa into copilot/consolidate-auth-flows-list Mar 28, 2026
1 of 2 checks passed
@PalmEmanuel
PalmEmanuel deleted the copilot/remove-workload-identity-credential branch March 28, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants