fix: update self.partitions with computed npart in HuarngPartitioner (closes #41)#53
Open
botbikamordehai2-sketch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
HuarngPartitionercomputes the number of partitions (npart) dynamically based on the data range and the empirically determined base interval. However, it never updatesself.partitionswith this computed value, soself.partitionsretains the default value of 10 from the parent class. This causes errors when fitting FTS models that rely onself.partitionsto determine the valid range of fuzzy set indices.Fix
Add
self.partitions = npartafter computingnpartin thebuildmethod, so that the partitioner correctly reports the actual number of fuzzy sets it created.Closes #41