feat(normalization): add 128-byte static RMS Norm tile - #139
wangyuascend-spec wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3aabfd6cb3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| make TESTCASE=rms_norm_static COMPILER_DIR="$COMPILER_DIR" DType=__half G_A=512 G_R=8192 PE_NUM=4 diss | ||
|
|
||
| # Fixed-shape static 4PE counterpart with a 128-byte FP32 compute Tile. | ||
| make TESTCASE=rms_norm_static_128b COMPILER_DIR=${COMPILER_DIR} DType=__half G_A=512 G_R=8192 PE_NUM=4 diss |
There was a problem hiding this comment.
Quote the compiler path in the new build command
When COMPILER_DIR contains whitespace, the unquoted expansion is split into multiple arguments, truncating the Make variable assignment and treating the remaining path component as an additional target, so this new testcase fails to build even though the preceding testcases accept the same path. Quote the expansion as COMPILER_DIR="$COMPILER_DIR", consistent with the two commands above.
Useful? React with 👍 / 👎.
Summary
Tile layout
Validation
Environment:
Result: