[one-level][normalization] Use tile subviews for RMSNorm binary cache - #121
wangyuascend-spec wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c714c17fcd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| cache_parent cache_tile = | ||
| TASSEMBLY<cache_parent>(std::move(initial_cache)); |
There was a problem hiding this comment.
Avoid unsupported vector tile assembly
In the default G_A=16, G_R=16384 path, execution reaches this assembly before producing any output, but both the fragments and parent are Location::Vec/RowMajor; the current ASL/model supports local B.ASSEMBLE only for Matrix/CUBE layouts, as documented in rowsum_subview_gfrun_issue.md:130-140. Consequently compilation succeeds but gfrun rejects the generated descriptor path with an illegal instruction, matching the failed validation recorded for this commit. Keep the cache in GM or lower it through an ISA-supported representation until Vector/NORM assembly is supported.
Useful? React with 👍 / 👎.
|
Updated in commit 22a7f6f:
Validation with DType=__half, G_A=16, G_R=16384, PE_NUM=4:
This confirms the removed shape adapters were not the cause of the model failure. |
Change
Baseline
Validation
Configuration: DType=__half, G_A=16, G_R=16384, PE_NUM=4, res_check=on.
The current ops-20260908 model rejects the RowMajor tile-subview operand/descriptor path used by this implementation, so this PR does not claim a passing accuracy result yet.