fix(normalization): harden dynamic 4PE solution validation - #114
Closed
wangyuascend-spec wants to merge 1 commit into
Closed
wangyuascend-spec wants to merge 1 commit into
wangyuascend-spec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up correction for the normalization solution merged in #113.
Validation
4PE gfrun accuracy on SuperScalarModel bc7fae00988a3296a849b5e138b83db433d6c4c8:
Forced-fourpe gfsim smoke:
Note: #113 is already merged, so it cannot be closed; this PR is its corrective follow-up.