-
-
Notifications
You must be signed in to change notification settings - Fork 135
Updates to plot and table functions #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
- Coverage 70.26% 70.17% -0.10%
==========================================
Files 20 20
Lines 5055 5073 +18
==========================================
+ Hits 3552 3560 +8
- Misses 1503 1513 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@rickecon This PR is ready for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves plotting and table functionalities by renaming several functions for clarity, introducing a more generic unstationarization utility for time series outputs, and updating documentation accordingly.
- Renames testing and utility functions (e.g., pct_change_unstationarized → unstationarize_vars, tp_output_dump_table → time_series_table).
- Adjusts handling of stationarized versus unstationarized data in plotting and table outputs.
- Updates package version and CHANGELOG to reflect the changes.
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_utils.py | Renamed tests to match updated utility functions. |
| tests/test_output_tables.py | Updated test to use the new time_series_table function. |
| setup.py | Bumped version to 0.14.2. |
| ogcore/utils.py | Replaced pct_change_unstationarized with unstationarize_vars and refactored computation. |
| ogcore/output_tables.py | Renamed table function and integrated unstationarization logic. |
| ogcore/output_plots.py | Adjusted default stationarized flag and unstationarizing logic. |
| ogcore/init.py | Updated version to 0.14.2. |
| CHANGELOG.md | Documented functional updates and renaming changes. |
Files not reviewed (4)
- docs/book/content/api/output_plots.rst: Language not supported
- docs/book/content/api/output_tables.rst: Language not supported
- docs/book/content/api/parameter_plots.rst: Language not supported
- docs/book/content/api/utils.rst: Language not supported
Comments suppressed due to low confidence (1)
ogcore/utils.py:1235
- [nitpick] Consider replacing 'np.arange(params.T)' with 'np.arange(T)' since T is already defined, to improve consistency and clarity.
prod_growth = np.exp(params.g_y * np.arange(params.T))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@jdebacker. I just submitted a PR to your branch (PR #36) that updates the |
Updates to README.md
|
@jdebacker. I think there is just one more change to fix in line 23 of |
|
@jdebacker. Great. Merging now. |
This PR addresses some issues with plot and table functions:
tp_output_dump_table(Issue Rename functiontp_output_dump_table#1008)output_plots.pyfunctions missing from API docs #1018)tp_output_dump_table(Issue Addstationarizedoption tooutput_tables.tp_output_dump_table#1019)plot_aggregates(Issue Default forstationarizedkwarg inplot_aggregates#1020)