Don't auto-optimize shared plans#466
Merged
jplacht merged 1 commit intoMay 19, 2026
Merged
Conversation
When I view https://prunplanner.org/shared/3b26959f-f281-41f6-bc12-343957c67e36 unlogged, I see 503/500 area used which isn't what my saved plan has. This is because the auto-optimized habs checkbox is set. I think it's unnecessary to check props.disabled in PlanView.vue for the planPerfs variable because it's only used for the binding of the value of the auto-optimized hab's checkbox. I think we want it checked for unsaved plans otherwise it uses the plan's settings. Before it was set to true for unsaved plans and shared plans (disabled == shared plans if you trace it through to usePlanningDataLoader)
👷 Deploy request for prunplanner-preview pending review.Visit the deploys page to approve it
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I view https://prunplanner.org/shared/3b26959f-f281-41f6-bc12-343957c67e36 unlogged, I see 503/500 area used which isn't what my saved plan has.
This is because the auto-optimized habs checkbox is set. I think it's unnecessary to check props.disabled in PlanView.vue for the planPerfs variable because it's only used for the binding of the value of the auto-optimized hab's checkbox. I think we want it checked for unsaved plans otherwise it uses the plan's settings. Before it was set to true for unsaved plans and shared plans (disabled == shared plans if you trace it through to usePlanningDataLoader)