Skip to content

Avoid padding Unity moves with tackle#107

Merged
intothehead merged 1 commit into
mainfrom
hotfix/unity-build-cache-version
Jun 23, 2026
Merged

Avoid padding Unity moves with tackle#107
intothehead merged 1 commit into
mainfrom
hotfix/unity-build-cache-version

Conversation

@intothehead

Copy link
Copy Markdown
Contributor

Pull Request

🎯 작업 내용

Unity 전투 스킬 모달에서 일부 포켓몬의 기술이 몸통박치기 4개로 표시되던 문제를 수정했습니다.

📌 작업 배경

배포 환경에서 일부 카드는 정상 기술이 표시되지만, 일부 카드는 스킬 모달에 몸통박치기만 4개 표시되는 문제가 있었습니다.

확인 결과 FE의 포켓몬 기술 데이터가 없는 경우 빈 슬롯을 모두 tackle로 채워 Unity에 전달하고 있었고, Unity는 전달받은 런타임 기술 목록을 그대로 표시하고 있었습니다.

🔨 구현 내용

Added (추가)

Changed (변경)

  • Unity WebGL 캐시 버전을 20260623-skill-modal-runtime-moves로 변경했습니다.
  • Unity 전투 세션 생성 시 유효한 move id만 payload에 포함하도록 변경했습니다.
  • 기술 슬롯이 부족할 때 FE에서 tackle로 강제 패딩하지 않도록 변경했습니다.

Fixed (수정)

  • 일부 포켓몬의 스킬 모달이 몸통박치기 4개로 표시되던 문제를 수정했습니다.
  • FE payload가 Unity의 로컬 기술 fallback을 덮어쓰던 문제를 수정했습니다.

📸 결과물

  • 별도 스크린샷 없음.
  • 배포 후 /battle에서 일부 포켓몬의 스킬 목록이 몸통박치기로만 채워지지 않는지 확인 필요.

🧪 테스트

  • corepack pnpm typecheck 통과.
  • 배포 환경에서 스킬 모달 기술명과 배틀 로그 기술명 일치 여부 확인.

💬 리뷰 요청사항

@intothehead
intothehead merged commit 51cf4ba into main Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@intothehead, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 13 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d07f667a-8036-4f0d-a804-a5bee86069b9

📥 Commits

Reviewing files that changed from the base of the PR and between 48e5b99 and a33c114.

📒 Files selected for processing (1)
  • src/features/unity-battle/actions/unityBattleActions.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/unity-build-cache-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant