Closed
Conversation
- Move communicators.py and decomposition.py to mpi/ - Move runner.py and runner_helper.py to helpers/ - Rename jacobi.py to solver.py - Update all internal imports Structure: Poisson/ ├── solver.py, kernels.py, problems.py, datastructures.py ├── mpi/communicators.py, decomposition.py └── helpers/runner.py, runner_helper.py 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove n_ranks=1 from MPI tests (sequential covered by test_solver) - Combine test_no_errors + test_converged into test_runs_and_converges - Remove duplicate convergence test from test_kernels (kept in MPI tests) - Reduce convergence grid sizes [15,25,45] → [15,25] - Reduce max_iter 50000 → 20000 for convergence tests Result: 68 → 61 tests, 17.9s → 13.6s (24% faster) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Tests like "shape is (N,N,N)" and "dtype is float64" are implicitly verified by solver convergence tests. If these were wrong, convergence would fail. Also fix test_kernels.py helper function removed by linter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Mocked MPI tests don't verify real behavior - if communicators break, integration tests will catch it. Keep test_decomposition.py (pure logic). 68 → 40 tests, 17.9s → 13.0s 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- test_solver.py: 123 → 54 lines (use fixtures, merge similar tests) - test_mpi_integration.py: 152 → 58 lines (single fixture, flat structure) - Remove redundant test classes and duplicate assertions 68 → 28 tests, 17.9s → 10.7s (59% fewer, 40% faster) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.