fix: added support for the internal void type in generated headers#1646
Merged
Angus-Bethke-Bachmann merged 3 commits intomasterfrom Mar 31, 2026
Merged
fix: added support for the internal void type in generated headers#1646Angus-Bethke-Bachmann merged 3 commits intomasterfrom
Angus-Bethke-Bachmann merged 3 commits intomasterfrom
Conversation
mhasel
reviewed
Mar 30, 2026
Comment on lines
+24
to
+25
| uint64_t* __vtable; | ||
| uint64_t* _Internal_; |
Member
There was a problem hiding this comment.
The plc __VOID type is represented here as uint64_t* - this might be misleading for C/C++ developers and lead to them using this with intent that the actual underlying type does not support.
Contributor
Author
There was a problem hiding this comment.
I had a quick catch-up chat with @ghaith, and the reason we were thinking of using ints initially was due to the way we interpret void. I will verify that the IR handles void types as void (i.e. not ints), and if this is the case (which we suspect it is), then we can have the header generate the c void type for them. I will also write a quick lit test to prove the case works as intended.
mhasel
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Tests