Skip to content

Clarify ignore patterns in Advanced Usage documentation#107

Merged
jrfnl merged 2 commits into
PHPCSStandards:mainfrom
JohnnyWalkerDigital:main
Apr 6, 2026
Merged

Clarify ignore patterns in Advanced Usage documentation#107
jrfnl merged 2 commits into
PHPCSStandards:mainfrom
JohnnyWalkerDigital:main

Conversation

@JohnnyWalkerDigital

@JohnnyWalkerDigital JohnnyWalkerDigital commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Description

Updated the ignore patterns explanation to clarify that they are case-insensitive regular expressions and provided additional details on escaping dots in file extensions.

Related issues/external references

Closes PHPCSStandards/PHP_CodeSniffer#1405

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include my changes under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have verified that my changes comply with the projects coding standards.
  • [-] [When adding a new Wiki page] I have added the new page to the _Sidebar.md file.
  • [-] [When adding/updating output examples] I have verified via the GitHub Actions artifact that the pre-processing handles the command correctly.

Updated the ignore patterns explanation to clarify that they are case-insensitive regular expressions and provided additional details on escaping dots in file extensions.
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

=== This is an auto-generated comment ===

Thank you for your PR.
A dry-run has been executed on your PR, executing all markdown pre-processing for the wiki files.

Please review the resulting final markdown files via the created artifact.
This is especially important when adding new pages or updating auto-generated output blocks.

N.B.: the above link will automatically be updated when this PR is updated.

@jrfnl jrfnl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR and making those improvement @JohnnyWalkerDigital ! Could you remove the parentheses around the sub-phrase ? Other than that, all good and ready for merge.

Comment thread wiki/Advanced-Usage.md Outdated
Clarified the explanation of ignore patterns for PHP_CodeSniffer.

@jrfnl jrfnl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @JohnnyWalkerDigital !

@jrfnl jrfnl merged commit 5c65c5f into PHPCSStandards:main Apr 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

*.js is excluding more files than expected

2 participants