chore(docs): audit every screenshot for identity and branding leaks - #830
Merged
Conversation
An audit of all 70 committed screenshots found six leaking the deployment's identity: the site title "PoGO Alerts Network" and the custom back-to-map nav link in the toolbar, and on three of them the account holder's Discord avatar photo still showing around the rim of an undersized silhouette overlay pasted by an earlier pass. pokemon-add-dialog, fort-changes-add-dialog and scope-picker were retaken against an anonymous session on a dev instance, with the title reset and the nav link removed before capture. areas and both copies of user-menu had only their 64px toolbar band replaced. Re-shooting them would have traded a configured pin, three places and four selected areas for an empty-state page, and the band splice was verified to differ from the original in exactly three column runs: the title text, the nav icon and the avatar. The remaining 64 images are clean.
The Pikachu card behind the add dialog read "IV 200-100%" -- stray test data from verifying a v2 tracking endpoint, not something documentation should show. Retaken against a Pikachu rule filtered to 90-100% IV, same framing and same anonymisation as before. The help page carried a byte-identical copy of the same shot, so it is replaced too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release housekeeping: an audit of every committed screenshot, and one duplicated changelog entry.
The screenshot audit — 70 of 70, checked visually
Two images were recently found carrying the deployment's site title and a real Discord avatar. The other 68 had never been looked at. All 70 have now been opened and inspected individually.
Six images leaked, across eight paths (
areas.pngandpokemon-add-dialog.pngare byte-identical betweendocs/screenshots/and the help assets). All six carried the "PoGO Alerts Network" title and the custom back-to-map nav link; four carried a real Discord avatar photo.The avatar cases share one cause, and it is the finding worth recording: an earlier anonymisation pass pasted a grey circle about four pixels too small and offset up-left, leaving skin, hair and background visible in a crescent around the rim. It reads as clean at a glance, which is exactly why it survived a previous "these are anonymised" pass.
No real names anywhere. No hostnames — none of the images capture browser chrome.
How each was fixed
Three dialog shots were retaken on the dev instance with a self-minted anonymous token (
username: Trainer, noavatarUrl), title reset and nav link removed before capture. Those also fix a staleness problem: their sidenav predated Pokéstop Events.areas.pngand both copies ofuser-menu.pnggot a toolbar-band splice instead — re-shootingareas.pngwould have traded a configured pin, three places and four selected areas for an empty-state page. The paste was verified to differ from the original in exactly three column runs (title text, nav icon, avatar) and nothing else.Every produced image was read back and looked at.
A second pass, after bad test data was spotted
Two of the retakes captured a Pikachu card reading "IV 200-100%" — stray test data of mine on the dev account, created while verifying a v2 endpoint and wrongly believed not to have been written. Deleted (uid 36471).
The images were retaken with a sensible demo rule (Pikachu,
min_iv: 90) which was removed afterwards; the account is back to zero pokemon rules. That sweep turned up a third affected file —assets/help/pokemon-add-dialog.pngwas a byte-identical copy of the old docs shot. The other 67 images are clean of the artifact.Worth carrying to the upstream report: v2 accepted
min_iv: 200with a 200 and no complaint, when IV is 0–100.The duplicated changelog entry
[Unreleased]carried two near-identical "The PoracleNG version compatibility page has been rewritten" bullets. They differed in one place: one said "5.1.0 versus 5.2.0 and newer", the other "5.1.0 versus 5.2.1".Every capability gate in the code compares against 5.2.0. The 5.2.1 wording was the stale phrasing the documentation audit had specifically corrected, so deleting the wrong one would have reintroduced that error into the published release notes. The 5.2.0 variant is kept. 36 bullets, no duplicates.
Found but deliberately not acted on
Geography. Real locations appear far more widely than the one image previously flagged. Richmond, Virginia recurs across nine images by area name, and
dashboard.png's coverage panel draws polygons over it with Lynchburg, Roanoke, Blacksburg and Petersburg labelled. Sharper: three images show street-level maps with legible road names in Glen Allen, VA, while the address caption beside them reads the fake "123 Main Street, Springfield, IL" — the caption was anonymised and the map underneath was not. Separately,areas.pngandplaces-section.pngshow a San Francisco pin and three saved places at precise coordinates labelledparents,the gymandwork.None of that is on the current anonymisation list. It is a maintainer decision, not something to change silently.
A real UI inconsistency, filed separately:
profiles.pngshows "5 Duplicates" in the summary chip against "Duplicates 13" in the filter chip, on the same page at the same moment. Every other count on that screen reconciles.Documentation quality, not leaks:
dashboard-bottom.pnganddashboard-weather.pngare pixel-identical todashboard.pngdespite their names; some images greet "DocUser" and others "Trainer"; and site titles vary across the set ("PoracleWeb.NET", "DM Alerts"), so the collection does not read as one instance.