chore(i18n): translate the Pokéstop Events strings - #822
Merged
Conversation
#817 shipped the Pokéstop Events feature with its 29 new keys carrying the English text verbatim in da, de, es, fr, it, nl, pl, pt, pt-BR and sv. Key parity held, so nothing rendered as a raw key and no test caught it -- the page simply read in English beside a sidebar that did not. Terminology follows the INVASIONS.EVENT_TYPES block each locale already had, so the event names on the new page match the chips the invasion list has been showing all along. The one departure is French, where SHOWCASE was "Présentation"; Niantic's French term is "Vitrine", so both the existing chip and the new strings now use it. The other five features merged today (#815, #816, #818, #819, #821) were checked the same way and were translated properly. What still matches English in them is legitimately identical in that language: "Costume" in French and Italian, "Event" in German, "Area" in Italian, "Gym", "Pokestop", "Station", "15 min" and the countdown abbreviations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #817, which shipped its 29 new keys as verbatim English in all ten non-English locale files. Key parity held so nothing rendered raw, but the Pokéstop Events page read untranslated beside a nav that was not.
Scope
Only #817 was affected. I diffed each of today's other five feature commits and they translated properly, so this is 29 keys × 10 files (French gets 30, see below).
POKESTOP_EVENTS.*NAV.POKESTOP_EVENTS,DASHBOARD.CARD_POKESTOP_EVENTS,..._SUBADMIN_SETTINGS.DISABLE_SHOWCASE_LABEL/_DESCTerminology came from what was already on screen
Each locale already had a translated
INVASIONS.EVENT_TYPESblock — the invasion chips have been rendering Showcase, Kecleon and Gold Stop names all along. Those were used as the reference so the new page and the existing chips agree rather than inventing a second vocabulary:Fremvisning/Gylden PokéStop(da),Gold-PokéStop(de),Exhibición/PokéParada dorada(es),Esibizione/Pokéstop d'oro(it),Gouden PokéStop(nl),Pokaz/Złoty PokéStop(pl),Exibição/PokéStop dourada(pt, pt-BR),Uppvisning/Gyllene PokéStop(sv).ptandpt-BRdiverge throughout, as they should — Europeanguardar/eliminar/Tenta outra vezagainst Braziliansalvar/excluir/Tente de novo.Kecleon is identical in all ten: it is a Pokémon name, shared across EN/FR/DE/ES/IT, and da/nl/pl/sv have no game localization for it.
One correction outside the new keys
French
INVASIONS.EVENT_TYPES.SHOWCASEread "Présentation". Niantic's French term is "Vitrine". The existing chip is corrected too, rather than leaving the page and the chip disagreeing — that is French's thirtieth key.Found while sweeping, deliberately not fixed here
en.jsonis inconsistent about "Pokéstop". Four spellings coexist:Pokéstop Events,PokéStop Events,Pokestop Changes, and lowercasepokestopin help text. The in-game spelling is PokéStop. Normalizing it touches keys well outside this branch.frandithold accent-stripped strings —POKEMON.SNACK_CREATED_WITH_DUPLICATESreads "creee(s)… deja suivie(s)" and "gia tracciato/i". Pre-existing, from a much older PR.TEMPLATE.COND_*block, fiveADMIN_SETTINGS.*, twoADMIN.APPROVAL_*, fourRAIDS.LEVEL.*, twoMAX_BATTLES.*andALARM_INFO.PING_TOOLTIP. Worth its own branch.Verification
All eleven files parse, 1813 keys in every one, zero missing, key order preserved.
npx jest --ci— 116 suites, 1389 tests, includinglocale-parity.spec.ts.prettier --checkclean.