fix(pokemon): the PVP league name needs 5:1, not 3.5:1 - #802
Merged
Conversation
#801 moved the league name from #f57f17 to the cp-pill #e65100 and its comment claimed that cleared 4.5:1. Measured on the dev deployment against the band's #f5f5f5 it is 3.48:1 -- an improvement on 2.4:1, and enough for large text, but this label is 12px. #bf360c measures 5.08:1. Ratios in the comment are now the measured ones.
hokiepokedad2
force-pushed
the
fix/800-pvp-league-contrast
branch
from
August 24, 2026 01:33
64558e8 to
0ae5b86
Compare
…-contrast # Conflicts: # CHANGELOG.md
#801 and #802 fix the same band on the same card for the same issue, and each wrote its own bullet with an identical lead sentence. Keeping both would publish the fix twice under one issue number. #802's wording supersedes: it describes the league name as darker rather than merely having gained contrast, which is what the 5:1 ratio actually did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #801 (issue #800).
That PR moved the league name from
#f57f17to the cp-pill#e65100and its comment claimed the new colour cleared 4.5:1. Measured on the dev deployment, against the band's#f5f5f5, it is 3.48:1 — better than the 2.4:1 it replaced, and enough for large text, but this label is 12px at weight 500, so 4.5:1 is the bar.#bf360c(deep orange 900) measures 5.08:1. The comment now carries the measured ratios rather than an assumed one.The rank range that #800 was actually about is unaffected:
rgba(0, 0, 0, 0.64)on that band, verified rendering in dark mode on dev.