Improve test coverage#27
Merged
Merged
Conversation
BSnelling
reviewed
Feb 9, 2026
| | layer2 | Linear(in_features = 5, out_features = 10, bias = true) | relu | | ||
| | layer3 | Linear(in_features = 10, out_features = 1, bias = true) | identity | | ||
|
|
||
| The inputs to the network are given by `prey` (argument 0) and an array file (argument 1). |
Collaborator
There was a problem hiding this comment.
Is the core feature of this test case the mixture of a species and an array input to the NN? If so, it would be good to highlight that at the top of this README.
Collaborator
Author
There was a problem hiding this comment.
The core feature is rather that we have array input, I will highlight better in the README
|
|
||
| Test case for when a feed-forward neural network appears in one of the observable formulas, | ||
| and one of the ML model input arguments is given via an array file that takes condition | ||
| specific vales. |
Collaborator
There was a problem hiding this comment.
Suggested change
| specific vales. | |
| specific values. |
| @@ -0,0 +1,29 @@ | |||
| # Test Case 039 | |||
|
|
|||
| Test case for when a feed-forward neural network appears in one of the observable formulas, | |||
Collaborator
There was a problem hiding this comment.
How does this test case differ from 038? They both seem to be about condition specific array inputs.
Collaborator
Author
There was a problem hiding this comment.
38 is with array input inside the ODE model, while the other is condition specific array input in the observable formula. I will clarify
Co-authored-by: BSnelling <branwen.snelling@crick.ac.uk>
Co-authored-by: BSnelling <branwen.snelling@crick.ac.uk>
Co-authored-by: BSnelling <branwen.snelling@crick.ac.uk>
BSnelling
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 5 new test-cases. 1 is having a math expression in the hybridization table. The other 4 have array input for simulation-based hybridization.