NNModelStandard tests#75
Merged
Merged
Conversation
dilpath
approved these changes
May 19, 2026
Member
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Looks good. Currently missing is a test that the reconstructed pytorch module matches the original pytorch module, e.g. by evaluating the module forward method and seeing that the output is the same after reconstruction. But this is already nice, thanks!
Collaborator
Author
Fair point, I can likely quite easily add it to the PR |
BSnelling
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for NN yaml export via testing the roundtrip. This PR also removes some old code from the
petab_sciml/standarddirectory.See also #11