Repository navigation
feat: enterprise deployment (machine-wide MSI, policies, opt-in update check, winget) - #7
Merged
Merged
Conversation
Rotula.Files.Policy reads SOFTWARE\Policies\P4Software\Rotula from HKLM and HKCU (the computer wins, value by value) behind IPolicySource. Policies fix the language and the update check, suggest a default printer, keep user-folder add-ons from loading, and switch MCP printing or database access off. The MCP server applies them on top of its settings file and can only be restricted, never widened. ADMX with en-US and es-ES ADML ship in packaging/policies; tests check the template value names against PolicyNames.
Settings fixed by a policy are disabled with a "Managed by your organization" note. Help > Check for updates once a day is off by default; when the user or a policy switches it on, Rotula sends at most one anonymous GET of the GitHub latest-release API a day and shows a non-modal notice linking to the release page. Nothing is downloaded or installed. Version compare, schedule, parsing and the checker are UI-free with tests; HTTP is behind IReleaseFeed.
A WiX Toolset v5 project (packaging/msi, build tool only, not in Rotula.sln) installs Rotula per machine to Program Files with a Start menu shortcut, the .rotula association, ARP metadata and a fixed UpgradeCode with MajorUpgrade. build-installer.ps1 builds it from the signed stage folder, signs and verifies it like the setup exe, and publishes it. The Inno installer now accepts /ALLUSERS and /CURRENTUSER on the command line.
The installer manifest offers the per-user Inno installer and the machine-scope MSI (ProductCode read from the signed MSI, fixed UpgradeCode). Adds a Spanish locale manifest.
New docs/deployment.md covers silent installs, the MSI, exit codes, Intune, Group Policy, Configuration Manager and the policy settings. CONTRIBUTING and decisions now state the update-check rule precisely: no network traffic unless the user or an administrator enables it, and nothing is sent about the user.
This was referenced Oct 24, 2026
glenntosco
changed the base branch from
claude/project-thread-5e0lug-print-station
to
main
October 24, 2026 14:27
glenntosco
added a commit
that referenced
this pull request
Oct 27, 2026
feat: enterprise deployment (machine-wide MSI, policies, opt-in update check, winget)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Glenn · project thread
What changed and why
Assessment item 10. Stacks on #6 (print station), which stacks on #5. Merge in order; GitHub retargets each to
main.packaging/msi, WiX Toolset v5 SDK project, build-time tool only, not inRotula.sln): per-machine install to Program Files, Start menu shortcut,.rotulaassociation (ASSOCIATE=0turns it off), Apps & features metadata, fixed UpgradeCode{4B2C6076-5B82-411C-B751-EC4B70BEE9C6}with MajorUpgrade (same-version upgrades allowed, downgrades refused), no wizard.build-installer.ps1builds it from the signed stage folder and signs/verifies it like the setup exe; an unsigned MSI is renamed-UNSIGNED. The Inno installer now accepts/ALLUSERSand/CURRENTUSER.Rotula.Files.Policy,HKLM\SOFTWARE\Policies\P4Software\Rotula, HKLM wins over HKCU, behindIPolicySource):LanguageandUpdateCheck(locked, shown greyed with "Managed by your organization"),DefaultPrinter(a suggestion),UserAddOns=0,McpPrinting=0,McpDatabase=0(these can only switch things off). ADMX + en-US / es-ES ADML inpackaging/policies.Rotula, no version, no cookies, Windows proxy). SemVer compare, drafts/pre-releases ignored, release link built from the parsed version (never taken from the response). Non-modal notice; dismissing remembers that version. Never downloads or installs anything. CONTRIBUTING, decisions, SECURITY and the README privacy sections now state the rule precisely (owner-approved change to the old "no update checks" rule).elevationRequired, ProductCode + UpgradeCode), es-MX locale manifest;New-WingetManifest.ps1takes-MsiPathand reads the ProductCode from the signed MSI. Submission steps indocs/releasing.md. Nothing submitted.docs/deployment.md(Inno and msiexec switches, properties, uninstall, exit codes, Intune Win32 app + detection rules + ADMX ingestion, GPO, SCCM, policy reference), linked from both READMEs. 8 new strings in en + es. WiX listed in THIRD-PARTY-NOTICES as a build-only tool (MS-RL).How it was tested
DeploymentPolicyTests/AppUpdateCheckTests: SemVer compare, daily schedule, release parsing (drafts, pre-releases, bad answers, link not from the response), checker states, exact HTTP request shape (GET only, User-Agent and Accept only), policy reading and HKLM/HKCU precedence, ADMX/ADML checked against the registry names the code reads, MCP policy, view-model behaviour (locked language, forced update check, notice and dismissal, policy printer).Checklist
Strings.en.resxandStrings.es.resxTHIRD-PARTY-NOTICES.md; nothing new is redistributedCHANGELOG.mdupdatedNotes
LICENSE-THIRD-PARTY.txtfor the users. Documented, and joins the existing lawyer-review note.Generated by Claude Code