Repository navigation
fix(l10n): drop the printer vendor name from UI strings - #12
Merged
Merged
Conversation
…strings The English and Spanish connection-refused, port-validation and start-page subtitle strings named one printer brand. They now say "most label printers" and "ZPL-compatible printer", matching the pt-BR and fr-CA wording.
glenntosco
added a commit
that referenced
this pull request
Oct 27, 2026
fix(l10n): drop the printer vendor name from UI strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Glenn · project thread
What changed and why
Three English and Spanish strings still named one printer brand:
Print.Error.ConnectionRefusedPrint.Field.PortStart.Subtitlept-BR and fr-CA already used this neutral wording, so all four languages now say the same thing. Two XML doc comments in
AppSettingsandPrinterSettingsViewModelgot the same treatment. Test names that cite the ZPL programming guide's sample symbols are left alone, since they reference the spec.How it was tested
Text-only change; no keys added or removed, so resx parity tests are unaffected. CI build and tests.
Checklist
dotnet build Rotula.sln -c Releaseanddotnet test Rotula.sln -c Releasepass (CI)Rotula.Corestays at or above 80% line coverage (no code change)CHANGELOG.md: not needed for a wording fixbash scripts/check-hygiene.sh origin/main..HEADpassesGenerated by Claude Code