[FEATURE] Sync org-level Skillset field via generic org-fields map - #76
Open
John McCall (lowlydba) wants to merge 1 commit into
Open
[FEATURE] Sync org-level Skillset field via generic org-fields map#76John McCall (lowlydba) wants to merge 1 commit into
John McCall (lowlydba) wants to merge 1 commit into
Conversation
Replace the single-purpose scope-form-field/scope-org-field-id inputs with a generic org-fields input: newline-separated form-field=org-field-id pairs, matching the key=value multi-line convention other composite actions use for map-shaped string inputs (e.g. docker/build-push-action's build-args). Defaults to OvertureMaps' Scope and Skillset fields, so Skillset now syncs out of the box without any caller changes. Fixes #75 Signed-off-by: John McCall <john@overturemaps.org>
Eric Godwin (ericgodwin)
approved these changes
Aug 6, 2026
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the sync-issue-fields composite action to support syncing multiple issue form dropdown answers into org-level issue fields using a single org-fields mapping.
Changes:
- Replaced single Scope mapping inputs with a newline-delimited
org-fieldsmapping (form-field → org field ID). - Updated the action script to compute and apply multiple org field updates in one PATCH.
- Updated README documentation and examples for the new configuration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/actions/sync-issue-fields/action.yml | Reworks inputs and script to support syncing multiple org-level fields via org-fields. |
| .github/actions/sync-issue-fields/README.md | Documents the new org-fields input and updates usage guidance/examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the open question in #75 in favor of the generic option:
scope-org-field-idis replaced withorg-fields, a newline-separated list ofform-field=org-field-idpairs. Addingskillset(org field ID45229885) is now a default entry in that map instead of a second dedicatedskillset-form-field/skillset-org-field-idpair, so future org fields are a config change, not a code change.key=valueper line matches how other composite actions already take small maps as string inputs (docker/build-push-action'sbuild-args, for one) and stays diffable in a workflow file without JSON/YAML quoting.Behavior is otherwise unchanged: still one
PATCH, still skips fields already set by manual triage, still warns instead of failing on a422.This replaces
scope-form-field/scope-org-field-id, so it's a breaking change for any caller passing those inputs directly. Nothing in this repo does today (sync-issue-fieldshas no workflow callers yet), so there's no in-repo migration needed.Fixes #75