Refactor population model - #2249
Merged
Merged
Conversation
added 10 commits
July 29, 2026 22:06
DanRStevens
reviewed
Jul 30, 2026
added 2 commits
July 31, 2026 19:18
_Originally posted by @DanRStevens in #2249 (review)
_Originally posted by @DanRStevens in #2249 (comment)
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some basic/minor refactoring.
Changes
PopulationModel::update()to use a parameter object instead of a long list of parameters. This will aid in future updates where I intend to inject transient modifiers into the update loop that are tracked outside of the population model (e.g., first landing fertility bonus and mortality resistance).