Repository navigation
Sync VideoStudio production and reference logic - #37
Merged
Merged
Conversation
Adapt the current Orkas VideoStudio delta to the portable OVS core, tools, CLI/MCP surface, tests, and host-neutral skills. Retire local OCR, classify direct generation from the executable plan, harden subtitle path escaping, and add reference-led production guidance. Prompt audit: - Resident: keep only short router/craft pointers to production-method and reference workflows because route selection and final-review depth affect every relevant video task. - On-demand: place production-method, reference recreation, ecommerce, paired preview review, extracted-frame grounding, and caption-only revision procedures in line-specific skill references so they load only for affected work. - Dropped: remove local OCR setup/command guidance, numeric reference-fidelity scoring, and blanket anti-copy language because the retired tool, deterministic reference contract, and explicit preserve/may-change boundary now own those behaviors. - Non-prompt enforcement: executable-plan generation classification, delivery branching, CLI/MCP OCR removal, ffmpeg escaping, and regression coverage remain in code and tests rather than duplicated instructions. Verification: pnpm verify with explicit repository ffmpeg/ffprobe paths; 281 unit/integration tests passed in the normal suite, 35 video capability tests passed, 46 production E2E tests passed, and the preserved three-scene sample was visually inspected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source review
Verification
Prompt audit
Prompt-facing changes were reviewed across the effective skill assembly. Detailed production method and reference workflows are on-demand; deterministic classification, delivery branching, OCR absence, and escaping remain in code/tests. The incremental mixed-reference test adds no prompt change.