Feature/hots hitl rubric form - #181
Open
afifasultana-ai wants to merge 5 commits into
Open
Conversation
Each ICT coach now sees only teachers from their assigned schools. - Add ict_coach_school_assignments table + RLS migration - Seed 303 coach→school mappings across 51 ICT coaches - API: GET /coaching/teachers/dc-scores accepts coach_name query param; falls back to full region list if no assignments found - Frontend: SmartScheduleTab passes profile.full_name to loadTeachers; cache key bumped to v2 to bust stale data - CORS expanded to cover all local Vite ports (5173–5179, 8080–8099) - Add IctCoachSchoolAssignment SQLAlchemy model Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rewrite PindiSmartScheduleTab and PunjabSmartScheduleTab to use new HOTSDashboard component (mirrors DCDashboard: 3 stat cards, tabbed tiers, expandable HOTS indicator grid, offline banner) - Add HOTSDashboard.tsx for HOTS framework (6 indicators, PunjabTeacher type) - Fix Vite proxy: route /api to production Railway API to bypass CORS in dev - Fix authApiClient: use ?? instead of || so empty VITE_API_URL produces relative URLs that the Vite proxy intercepts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix HotsScores type: correct field names (classroom_management, lesson_planning, instructional_strategies, student_engagement, assessment_feedback, multigrade_setup) matching the DB schema - Fix HOTS_DIMENSIONS in observation-utils: correct 6 indicators with proper max values (CM/9, LP/9, IS/12, SE/9, AF/9, MG/3 = 51 total) - Fix getProficiencyLevel: thresholds aligned to PINDI_CRITICAL_PCT (60%) and PINDI_ON_TRACK_PCT (75%) — Needs Urgent / Follow-up / On Track - Add hotsTeachers.ts: upsertTeacherHotsScores() rolls up observation scores to rawalpindi_teacher_scores or punjab_teacher_scores, auto- detecting the correct table by cluster, and invalidates the hook cache - Wire HotsRubricForm into DraftObservationsTab for framework='HOTS'; FICO observations keep NeoAnalysis + neo_status submit gate unchanged Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ScheduleVisitModal: when framework='HOTS', Visit Type and Visit Purpose become free-text inputs (not ICT-specific dropdowns); FICO option removed from visit type list - ScheduleVisitModal: for HOTS, show editable Subject + Grade text inputs inline in the teacher card (Pindi teacher data has no subject/ grade, so coaches fill these in at observation time) - Pindi & Punjab schedule payloads: prefer formData.subject/grade over teacher.subject/grade so the coach-entered values are used - Fix observations.ts: use ?? instead of || so VITE_API_URL="" produces relative URLs that the Vite proxy intercepts (was falling back to localhost:8000 and failing silently) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: [Feature/Fix Description]
📝 Description
Closes: [JIRA-XXXX or GitHub Issue #XXX]
🎯 Type of Change
🔍 Changes Made
🧪 E2E Testing Checklist
Required before merging to staging:
npm run devtestcoach+staging+[random]@example.comauth.userstable📸 Screenshots (if UI change)
🔄 Deployment Checklist
🚨 Breaking Changes
If checked, describe the impact:
📋 Checklist
DEVELOPMENT_STANDARDS.md)stagingbranch🔗 Related Issues
👀 Reviewers
DO NOT MERGE until:
Remember: This goes to staging first, then production after staging QA passes.