prod: calendar key must come from the env — a container has no key file - #305
Merged
Conversation
… container has no key file The last thing between "configured" and "an invite actually arrives". google-calendar.client.js read the service-account key from GOOGLE_SERVICE_ACCOUNT_PATH — a FILE PATH. Railway containers have no such file, and the variable was not set on production at all, so isConfigured() returned false, the gate skipped every schedule, and not one invite was even attempted. Silent, because the whole calendar path is deliberately non-blocking: no error, no event, nothing in a coach's calendar and no obvious reason why. Now ENV FIRST, file second — the convention this project already documents (coos-088): GOOGLE_SERVICE_ACCOUNT_JSON for the cloud, the local file for a workstation. A bad path no longer breaks a working env var. 6 tests, red first, including the exact state prod was in (subject and calendar id set, no key of either kind => not configured). Suite: 15 failing before and after, zero regressions. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> (cherry picked from commit 6fb5fc9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick. The client read the service-account key from
GOOGLE_SERVICE_ACCOUNT_PATH(a file path). Railway containers have no such file and the variable wasn't set on prod, soisConfigured()was false, the gate skipped every schedule, and not one invite was even attempted — silently, because the path is non-blocking.Now env-first, file second, per the project's existing coos-088 convention. 6 tests red-first, including the exact state prod was in. 15 failing before and after, zero regressions.