fix(portal): label the mobile overflow tab "Other" rather than "More" (bd-2563) - #192
Merged
Conversation
… (bd-2563) The label lives in three places that have to agree: the visible tab text, the button's aria-label (what a screen reader announces), and the title of the sheet it opens. Changing one and missing another is the obvious way this goes wrong, so all three move together and all three are asserted. Also the first end-to-end exercise of remote-first OTA on a real device: this change reaches the installed staging app with no reinstall, via the staging portal rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small copy change — and the first end-to-end test of remote-first OTA on a real device.
The label lives in three places that have to agree:
aria-label(screen reader)Changing one and missing another is the obvious failure mode, so all three move together and all three are asserted.
Red-first: 3 failing → 13 files / 71 tests green.
Why this PR matters beyond the copy
Merging this rebuilds the staging portal. The OTA-capable
.debugapp already installed on a test handset should then pick the change up on force-close and reopen, with no reinstall — proving the loop that makes merge-to-main reach users.Closes: bd-2563
🤖 Generated with Claude Code