Skip to content

Warm restart: report a GPU quiesce failure to the caller - #43

Open
brkosebay wants to merge 46 commits into
OrchardLinux:mainfrom
brkosebay:j71t/warm-restart-shared
Open

brkosebay wants to merge 46 commits into
OrchardLinux:mainfrom
brkosebay:j71t/warm-restart-shared

Conversation

@brkosebay

Copy link
Copy Markdown
Contributor

Part 6 of 14 of the iPad 5 (J71t) series in this repository; merge after #37.

Problem

A warm restart went on even when the GPU could not be quiesced.

Change

Add the quiesce-gpu helper, which reports a failure to the restart caller. It runs wherever the G5P driver exposes its handover command and does nothing elsewhere. This branch also drops the Mac current opt-in flag of the closed #39, which it was stacked on.

Testing

  • Hardware: iPad 5 Wi-Fi (J71t). Hands-on testing on 2026-11-11 with an integrated build of this series, made before the final failure-path fixes, covered warm restart.
  • 2026-11-12: 20+ warm restarts with the GPU in use, several right after a glmark2 run, completed without a freeze.
  • Host: the Linux test suite passes at this branch's head (with Orchard at the top of its series).

Dependencies

Depends on #37.

This branch is stacked on the PRs it depends on and carries their commits; the change of this PR is its last commit, "Warm restart: report a GPU quiesce failure to the caller".

🤖 Generated with Claude Code

Bring this branch onto current main. The merge keeps the other side's
tree; the next commit carries the reworked version of this branch's
change.
Bring this branch onto current main and the series it depends on. The
merge keeps the other side's tree; the next commit carries the reworked
version of this branch's change.
Bring this branch onto current main and the series it depends on. The
merge keeps the other side's tree; the next commit carries the reworked
version of this branch's change.
Bring this branch onto current main and the series it depends on. The
merge keeps the other side's tree; the next commit carries the reworked
version of this branch's change.
Bring this branch onto current main and the series it depends on. The
merge keeps the other side's tree; the next commit carries the reworked
version of this branch's change.
Bring this branch onto current main and the series it depends on. The
merge keeps the other side's tree; the next commit carries the reworked
version of this branch's change.
Automatic rotation could not be overridden: there was no manual rotation
or lock in the menu.

Add omarchy-rotate with rotate and lock commands, menu entries for them,
and the release root wiring.

Assisted-by: LLM
The tablet had no lock on cover close, no dim before idle lock, and
suspend was offered even when the kernel could not complete it.

Lock on cover close, dim before the idle lock, disable hibernation, and
gate suspend on ipadlinux-suspend-ready, the kernel's readiness report.
Documented in docs/power-and-lock.md.

Assisted-by: LLM
The panel kept a fixed brightness; there was no automatic brightness
from the ambient-light sensor.

Add an optional, off-by-default automatic brightness daemon (generic IIO
lux or iio-sensor-proxy, no board calibration), a toggle in the Display
panel and its CLI.

Assisted-by: LLM
Orchard's guarded Mac current profile needs a device-side opt-in.

Opt J71t into the Mac current profile through
/etc/orchard/mac-usb-current, with a test.

Assisted-by: LLM
A chosen display scale was lost at the next login, and after a scale or
rotation change windows could end up off screen.

Add omarchy-display-scale and a Display panel picker, restore the saved
scale at login, and gather windows on screen with Super+Shift+G.

Assisted-by: LLM
On a 1.5 GB device the default zram size and an unbounded journal waste
memory.

Size zram to RAM, favour compressed swap (swappiness, page cluster,
watermarks), bound the runtime and system journal, and quiet the
console.

Assisted-by: LLM
A warm restart went on even when the GPU could not be quiesced.

Add the quiesce-gpu helper, which reports a failure to the restart
caller.

Assisted-by: LLM
Bring this branch onto current main, which now has the Smart Cover lock
and wake in omarchy-powerd.
Bring this branch onto current main, which reads the Smart Cover in
omarchy-powerd: closing it is a lock, opening it a wake. That replaces
this branch's cover-close and cover-suspend socket requests and their
test. A sleep after a cover lock goes through the same suspend
readiness check as Power and idle, which the merged test now covers.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
An earlier wording pass on this branch turned "owner" into
"maintainer" in lines that come from main: powerd is the one owner of
the screen, the lock request and sleep, and the shutdown menu test
quotes that. Restore main's wording in the state model doc, the
powerd comment and the test.

Assisted-by: LLM
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
The sensor test's note on a hands-on check named no person but read as
a maintainer's report; call it a hands-on test. The tablet sensor
notes call the power daemon the sole owner of screen-off and sleep, as
the power state model does.

Assisted-by: LLM
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Orchard main now gives every installed system the Mac current
identity (0x1014) on its own, and nothing reads
/etc/orchard/mac-usb-current any more, so the notes on opting in with
that flag describe a switch that no longer exists.

Assisted-by: LLM
ipadlinux-suspend-ready first asked Orchard's device-feature helper
whether the board's feature table marked suspend as working. Orchard
does not ship that table: feature states describe a board, they do not
switch behaviour. Without the helper every sleep request was refused.

Decide from the kernel's own admission query on every board instead.
/sys/power/suspend_ready answers "ready" or names the first driver or
precheck that would refuse; a kernel without the query cannot show
that a suspend would be admitted, so sleep stays refused there, as do
an unreadable or malformed answer. The helper no longer reads the
board identity. Powerd, the session menu and systemd's direct suspend
guard keep calling the same helper.

Assisted-by: LLM
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
Bring this branch onto current main and the series it depends on.
This branch was stacked on the Mac current opt-in (OrchardLinux#39), which was
closed: Orchard main now uses the Mac current identity on every
installed system, and nothing reads /etc/orchard/mac-usb-current. Remove
the flag file and its test, so this branch and the ones after it do
not carry that change.

Assisted-by: LLM
quiesce-gpu ran only when Orchard's device-feature helper said the
board's warm_restart feature was working. Orchard does not ship that
helper, so the GPU was never quiesced. Decide from the mechanism
instead: when the G5P driver exposes its handover command, arm the
failure receipt and send td-kexec as before; without it there is
nothing to quiesce and the helper exits without arming anything.

Assisted-by: LLM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant