Repository navigation
Test pushes and pull requests against the pinned hardware and cli - #20
Merged
henrikklee merged 1 commit intoOct 30, 2026
Merged
Conversation
The test job installed the v0.1.10 wheel pair on every run, but main pins hardware and cli commits that are newer than that release, and three recovery tests depend on them (capture-adt --size, manifest outputs). The job has failed on every push since the torvalds-based move. Pushes and pull requests now install the pinned submodules; tags and manual dispatches still install the published pair they release with. With the submodules installed all 79 tests pass locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob has failed on every push to main since the torvalds-based move (#7). It's the same 3 errors each time:test_recovery_adt_endpoint_owns_size_and_exact_binary_selection:capture-adt --sizeexits 2.test_actual_recovery_root_lock_and_public_hashes_are_checked:KeyError: 'outputs'.test_public_recovery_cannot_contain_firmware_or_session_credentials:KeyError: 'outputs'.The job installs the v0.1.10 wheel pair (
HARDWARE_TAG/CLI_TAGdefault) on every run, but main pins newerhardware/clicommits, and those tests exercise the newer code (requirements-build.txtalready asks fororchard-hardware>=0.1.11). Locally, with./hardwareand./cliinstalled at the pinned commits, all 79 tests pass (1 skipped).Change:
./hardware ./cli, thenpip check.ci/dependencies --wheels-only(published or artifact wheel pair with version check), so a release is still tested against exactly what it ships with.When v0.1.11 is published and the defaults move to it, the two paths converge again.
🤖 Generated with Claude Code