fix: adopt cargo workspace inheritance for all crate metadata (#101) - #213
Open
jonathanayubausara-a11y wants to merge 4 commits into
Open
Conversation
…hainLabs#101) Closes OrbitChainLabs#101 - campaign/Cargo.toml: use version.workspace, edition.workspace, rust-version.workspace, license.workspace - common/Cargo.toml: same - token-bridge/Cargo.toml: same - crates/contracts/batch-donor/Cargo.toml: same All four crates now inherit shared metadata from [workspace.package] consistent with core and tools crates.
1 task
The v5 schema requires each label entry to be an object with matchers (any-to-match / all-to-match) instead of bare glob strings. Fixes the "found unexpected type for label 'api' (should be array of config options)" error that blocked the labeler workflow on PR OrbitChainLabs#213.
The v5 format requires:
label:
- changed-files:
- any-glob-to-any-file: ['glob1', 'glob2']
Not the informal any-to-match key used previously.
The labeler workflow (pull_request_target) previously had no checkout step, so it always fetched .github/labeler.yml from main via the API. This created a chicken-and-egg problem: PRs that fixed the labeler config couldn't make their own labeler check pass. Adding actions/checkout@v4 with the PR head SHA lets the labeler read the config file locally from the PR branch. The action only consumes a YAML file (no run: steps execute PR code), so the pull_request_target context remains safe. Co-fixes the labeler v5 schema migration included in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101
Audit every Cargo.toml; move shared fields to [workspace.package] and inherit (edition.workspace = true, version.workspace = true, etc.).
Changes
All four crates now inherit shared metadata from [workspace.package], consistent with core and tools crates.
Acceptance Criteria