Remove cuber-side CDCL learning - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The cuber-side CDCL companion was an experimental mechanism that let a SAT solver learn clauses before conquer. It is no longer part of the intended solver design. Keeping it left two propagation systems, extra dependencies, and a broad configuration surface in the production cuber.
Impact
cnc_cuberno longer accepts--propagationor--propagate-cnf. Cube generation now has one propagation implementation and reports native-only trace provenance. The public cubing API retains the direct cutoff/configured entry points and removes compatibility-only forwarding functions.Validation
cargo test --all-targetsPYTHONPATH=. uv run pytest tests/test_benchmark_pipeline.py tests/test_benchmark_scope.py tests/test_cnc_trace_mechanism.py tests/test_conquer_parallel.py tests/test_cubing.py tests/test_factoring_corpus.py tests/test_solve.py— 41 passedcargo fmt -- --checkgit diff --checkcargo clippy --all-targets— completed with existing warnings in unchanged files