Skip to content

Remove cuber-side CDCL learning - #60

Merged
isPANN merged 1 commit into
mainfrom
codex/native-cnc-cleanup
Jul 26, 2026
Merged

Remove cuber-side CDCL learning#60
isPANN merged 1 commit into
mainfrom
codex/native-cnc-cleanup

Conversation

@isPANN

@isPANN isPANN commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the cuber-side RustSAT/CaDiCaL dependency and learned-clause propagation path
  • keep cube generation on the native Compact-Table propagation engine; the flattened CNF is used only by Kissat conquer workers
  • remove the obsolete propagation CLI/state, compatibility wrappers, trace fields, documentation, and CDCL-specific tests

Why

The cuber-side CDCL companion was an experimental mechanism that let a SAT solver learn clauses before conquer. It is no longer part of the intended solver design. Keeping it left two propagation systems, extra dependencies, and a broad configuration surface in the production cuber.

Impact

cnc_cuber no longer accepts --propagation or --propagate-cnf. Cube generation now has one propagation implementation and reports native-only trace provenance. The public cubing API retains the direct cutoff/configured entry points and removes compatibility-only forwarding functions.

Validation

  • cargo test --all-targets
  • PYTHONPATH=. uv run pytest tests/test_benchmark_pipeline.py tests/test_benchmark_scope.py tests/test_cnc_trace_mechanism.py tests/test_conquer_parallel.py tests/test_cubing.py tests/test_factoring_corpus.py tests/test_solve.py — 41 passed
  • cargo fmt -- --check
  • git diff --check
  • cargo clippy --all-targets — completed with existing warnings in unchanged files

@isPANN
isPANN marked this pull request as ready for review July 26, 2026 15:50
@isPANN
isPANN merged commit 6035bcd into main Jul 26, 2026
1 check passed
@isPANN
isPANN deleted the codex/native-cnc-cleanup branch July 26, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant