Conversation
- Add custom error classes for DCP command handling (replaces magic strings) - Validate purgeErrors.turns and turnProtection.turns >= 1 (prevents data loss) - Replace silent error swallowing with console.error fallback in logger - Add config validation warning for invalid turns values Fixes: - Magic string error control flow anti-pattern - Potential immediate pruning of all errors with turns=0 - Silent error hiding in logger methods
Changes: - Remove custom error classes - revert to simple error strings (maintainer confirmed strings aren't matched, just used for control flow) - Add devError method to logger for developer-only errors (no TUI output) - Expand numeric validation to all fields: - nudgeFrequency: validate >= 1, clamp at runtime - turnProtection.turns: validate >= 1 (already has runtime check) - purgeErrors.turns: already validated >= 1 - Add runtime clamping for nudgeFrequency in inject.ts Fixes maintainer concerns: 1. Custom error classes were overkill for simple control flow 2. Numeric validation now covers all numeric config fields
…ents fix: critical bugs and error handling improvements
…older-migration Feat/dev compress id placeholder migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compress rewrite and some safer code stuff