Skip to content

build: bump Sui CLI to 1.73.2#401

Open
bidzyyys wants to merge 1 commit into
mainfrom
build/bump-sui-v1.73.2
Open

build: bump Sui CLI to 1.73.2#401
bidzyyys wants to merge 1 commit into
mainfrom
build/bump-sui-v1.73.2

Conversation

@bidzyyys

@bidzyyys bidzyyys commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps the required Sui CLI version from 1.72.5 to 1.73.2.

  • .github/workflows/test.ymlSUI_VERSION env updated to 1.73.2
  • README.md — documented required version + release link updated

Mirrors the established bump pattern (cf. #368, #324): only the two version-pin sites are touched. Published.toml toolchain-version fields are publish-time artifacts and are intentionally left untouched.

Verification

CI runs the full build/test suite against the new CLI version.

Summary by CodeRabbit

  • Chores

    • Updated Sui CLI version requirement from mainnet-v1.72.5 to mainnet-v1.73.2
  • Documentation

    • Updated installation documentation to reflect the new Sui CLI version requirement

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Sui CLI version is bumped from 1.72.5 to 1.73.2 in two places: the SUI_VERSION environment variable in the CI workflow (.github/workflows/test.yml) and the required version reference in the README installation instructions.

Changes

Sui CLI Version Bump

Layer / File(s) Summary
CI workflow and README version update
.github/workflows/test.yml, README.md
SUI_VERSION env var updated to 1.73.2 in the workflow, and the README "Required version" entry updated to mainnet-v1.73.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • OpenZeppelin/contracts-sui#314: Same pattern of bumping env.SUI_VERSION in .github/workflows/test.yml and the README required Sui CLI version to a newer release.
  • OpenZeppelin/contracts-sui#324: Identical change structure — bumps env.SUI_VERSION and the README Sui CLI required version (1.71.1 → 1.72.2).
  • OpenZeppelin/contracts-sui#368: Direct predecessor version bump modifying the same env.SUI_VERSION in the workflow and the README required Sui CLI version.

Suggested reviewers

  • immrsd
  • ericnordelo

Poem

🐇 Hippity-hop, a version has changed,
From 1.72.5, now rearranged!
The workflow now fetches 1.73.2,
README agrees — it's shiny and new.
A tiny bump, but the bunny approves! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping Sui CLI version from 1.72.5 to 1.73.2, which directly matches the changeset.
Description check ✅ Passed The description provides a comprehensive summary with context, specific file changes, verification details, and references to the established bump pattern, but does not follow the template structure with PR Checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/bump-sui-v1.73.2

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (a9703fe) to head (1564905).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   78.88%   78.88%           
=======================================
  Files          23       23           
  Lines        1781     1781           
  Branches      642      636    -6     
=======================================
  Hits         1405     1405           
  Misses        341      341           
  Partials       35       35           
Flag Coverage Δ
contracts/access 65.46% <ø> (ø)
contracts/utils 44.09% <ø> (ø)
math/fixed_point 56.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/test.yml:
- Line 19: The toolchain-version field in the Published.toml configuration files
is not aligned with the SUI_VERSION update to 1.73.2 in the test.yml workflow.
Locate and update the toolchain-version entries from 1.72.5 to 1.73.2 in
contracts/utils/Published.toml (update both occurrences on lines 10 and 19) and
math/core/Published.toml (update line 10) to ensure consistency across all
configuration files.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e4647de0-aa07-4b3c-8473-e192bf3f5ed3

📥 Commits

Reviewing files that changed from the base of the PR and between a9703fe and 1564905.

📒 Files selected for processing (2)
  • .github/workflows/test.yml
  • README.md

Comment thread .github/workflows/test.yml

@ericnordelo ericnordelo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants