chore: code-style fixes per STYLEGUIDE

[bidzyyys]

General code-style cleanup against STYLEGUIDE.md. Does not close any issue.

Changes

• STYLEGUIDE.md — codify doc-comments as the API source of truth (rendered by sui move build --doc, consumed by AI-integrator tooling):
  • #### Aborts lists every error a function can raise, including errors propagated from internal calls;
  • state caller preconditions and map each to its error;
  • #### Parameters / #### Returns only where they add detail beyond the one-line summary (a trivial getter needs neither);
  • pin-exact exception: approximation tests that check an on-chain result against an off-chain mathematical reference within a tolerance (e.g. assert!(diff < epsilon)) stay bound-based — do not convert to assert_eq!.
• Struct field docs — document the hot-potato struct fields in access (delayed/two_step Borrow, two_step RequestBorrow) and fixed_point Components.
• Test naming — drop the test_ prefix from access_control_tests functions (descriptive names per STYLEGUIDE Testing), matching the sibling test modules.

Verification

sui move test --build-env testnet --lint --warnings-are-errors and sui move build --doc --build-env testnet, all green:

• contracts/access — 137 tests
• math/core — 753 tests
• math/fixed_point — 426 tests

Out of scope (follow-up)

access_control_tests still carries #[allow(lint(...))] (4) and abort 999 sentinels (43); removing them requires restructuring the expected-failure tests (and resolving share_owned) and is left to a separate focused PR.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Documentation
  • Expanded public documentation standards to require complete #### Parameters, #### Returns, and detailed #### Aborts listings.
  • Updated API docs across math and access components with explicit abort/error codes and clearer explanations.
  • Added field-level documentation for public structs and refreshed the project’s introductory wording.
• Tests
  • Expanded and renamed AccessControl tests, adding more negative and boundary coverage plus a regression for correct pending-state cleanup.

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.88%. Comparing base (1ab78d8) to head (7b5b407).

Files with missing lines	Patch %	Lines
math/core/sources/u128.move	0.00%	1 Missing ⚠️
math/core/sources/u16.move	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   78.90%   78.88%   -0.02%     
==========================================
  Files          23       23              
  Lines        1782     1781       -1     
  Branches      640      642       +2     
==========================================
- Hits         1406     1405       -1     
  Misses        341      341              
  Partials       35       35              

Flag	Coverage Δ
contracts/access	65.46% <0.00%> (+0.05%)	⬆️
contracts/utils	44.09% <0.00%> (ø)
math/fixed_point	56.51% <0.00%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bidzyyys]

@ericnordelo https://move-book.com/guides/code-quality-checklist/#do-not-prefix-tests-with-test_-in-testing-modules

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Expands STYLEGUIDE.md with a bound-based assertion exception for #[random_test] and stronger doc-comment #### Aborts requirements. Adds field-level doc comments to the Borrow, RequestBorrow, and Components public structs. Updates math module abort documentation to specify error codes. Updates llms.txt intro wording. Renames access-control test functions and adds cancel-state regression and exact-delay boundary coverage.

Changes

Style Guide, Documentation, and Test Updates

Layer / File(s)	Summary
STYLEGUIDE rule expansions STYLEGUIDE.md	Adds exception for bound-based #[random_test] assertions (must remain bound-based, not converted to assert_eq!) and expands the doc-comment mandate to require complete #### Aborts sections with all native and propagated internal-call errors, plus explicit caller preconditions mapped to error codes.
Struct field documentation contracts/access/sources/ownership_transfer/delayed.move, contracts/access/sources/ownership_transfer/two_step.move, math/fixed_point/sources/sd29x9/sd29x9_base.move	Reformats Borrow and RequestBorrow into multi-line structs with per-field doc comments; adds doc comments to Components.neg field, implementing the expanded documentation rules.
Math module abort documentation specificity math/core/sources/u8.move, math/core/sources/u16.move, math/core/sources/u32.move, math/core/sources/u64.move, math/core/sources/u128.move, math/core/sources/u256.move, math/core/sources/decimal_scaling.move, math/core/sources/internal/macros.move	Updates abort documentation across arithmetic helper modules to explicitly list error codes (EDivideByZero, EZeroModulus, EInvalidDecimals) instead of generic phrasing, following the strengthened STYLEGUIDE #### Aborts requirements.
Access control test renaming and extended coverage contracts/access/tests/access_control_tests.move	Renames test functions across all lifecycle areas (constructor, grant/revoke/renounce, set_role_admin, queries, auth, transfer/renounce, delay changes) and adds regression coverage for cancel_default_admin_transfer fully clearing pending state and exact-delay boundary acceptance.
Repository prose updates llms.txt	Rewords introduction paragraph to emphasize "Audited, composable Move building blocks" and "reviewed primitives" with updated sentence flow.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• OpenZeppelin/contracts-sui#313: Introduced the access_control_tests.move module that this PR renames and extends with additional boundary coverage.
• OpenZeppelin/contracts-sui#370: Established the STYLEGUIDE.md conventions that this PR expands with #[random_test] and #### Aborts rules.
• OpenZeppelin/contracts-sui#394: Also modifies llms.txt intro text, making it a direct neighbor to this PR's wording update.

Suggested reviewers

• ericnordelo
• 0xNeshi

Poem

🐇 Hop, skip, and test—the style guide grew,
Aborts now precise, documented true!
Struct fields adorned with comments bright,
Test names reframed, boundaries tight.
Math modules squared with specifics clear—
This bunny's standards shine here! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: code-style fixes implementing STYLEGUIDE guidelines across the codebase.
Description check	✅ Passed	The description is comprehensive, covering all changes, verification steps, and out-of-scope work, but is missing the PR Checklist section from the template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/code-style-fixes

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[0xNeshi]

Excellent work

[ericnordelo]

LGTM!