[WIP] cpu: Save selective oracle replay experiment#899
Draft
jensen-yan wants to merge 4 commits into
Draft
Conversation
Change-Id: If81aed7f8033ad46741f36159f1122d5b0cf8248
Change-Id: I14c53614b85ca1da2c07502bee8e836db776baa6
Change-Id: I3b30137657501cc2d7939e1b566e02bfd26b01da
Change-Id: Ib70b056521d48c03999bd9ae58633b9804a74d31
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR saves the current selective BPU oracle replay experiment for later continuation.
The patch adds CSV record/replay parameters alongside the existing DB replay path:
selectiveOracleRecordCSVFileselectiveOracleReplayCSVFileCSV replay parses the old logical fetch-block format and feeds the existing filtered global replay stream instead of using a per-startPC FIFO. This preserves the useful short-window behavior for the mcf hot branch experiment while keeping the DB code path in place.
Status
This is experimental and not ready to merge as-is.
The short mcf check confirms that per-startPC FIFO was one source of bad alignment:
mcf_63881.5M, bad FIFO:0x1088c = 7083/30511mcf_63881.5M, CSV global replay:0x1088c = 1309/30511,TraceMissing = 1The full 40M check still does not recover the earlier stitched prototype:
0.493201, condMiss610605, recovery397593440.504425, condMiss516465, recovery34001448TraceMissing = 988164So the remaining issue is replay cursor drift over long runs, not CSV vs DB storage itself.
Validation
git diff --checkscons build/RISCV/gem5.opt --gold-linker -j64mcf_63881.5M CSV replay using/tmp/bpu_oracle_mcf_6388_record_dual/selective_oracle_blocks.csvmcf_638840M CSV replay using the same CSV27736blocks and38063outcomes