Skip to content

Fix GitInfo displays always being incorrect#453

Merged
Spartan322 merged 1 commit into
OpenVicProject:masterfrom
Spartan322:fix/git-info
May 20, 2025
Merged

Fix GitInfo displays always being incorrect#453
Spartan322 merged 1 commit into
OpenVicProject:masterfrom
Spartan322:fix/git-info

Conversation

@Spartan322

@Spartan322 Spartan322 commented May 16, 2025

Copy link
Copy Markdown
Member

Move GitInfo retrieval to GDExtension
Add .gdignore to game/export**

@Spartan322 Spartan322 added the bug Issue that describes something dysfunctional or erroneous label May 16, 2025
Hop311
Hop311 previously approved these changes May 16, 2025

@Hop311 Hop311 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows, all working 👍
Left some comments, mostly very minor, lemme know what you think

Comment thread extension/src/openvic-extension/singletons/GitInfo.hpp
Comment thread extension/src/openvic-extension/singletons/GitInfo.hpp Outdated
Comment thread extension/src/openvic-extension/singletons/GitInfo.cpp
Comment thread extension/src/openvic-extension/singletons/GitInfo.cpp Outdated
Comment thread extension/src/openvic-extension/register_types.cpp
Comment thread extension/src/openvic-extension/singletons/GitInfo.cpp Outdated
Comment thread SConstruct
@Spartan322
Spartan322 force-pushed the fix/git-info branch 5 times, most recently from a698f22 to 9768b14 Compare May 17, 2025 07:42
Hop311
Hop311 previously approved these changes May 18, 2025
Comment thread extension/src/openvic-extension/singletons/GitInfo.cpp Outdated
Comment thread SConstruct Outdated
Move GitInfo retrieval to GDExtension
Add .gdignore to game/export
@Spartan322
Spartan322 merged commit 724cead into OpenVicProject:master May 20, 2025
@Spartan322
Spartan322 deleted the fix/git-info branch May 20, 2025 22:40
@Spartan322 Spartan322 added topic:buildsystem Issue that applies to the buildsystem of the module, like modifying or improving the buildsystem topic:core Issue that applies to core functions, fundamental to the rest of the module labels Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue that describes something dysfunctional or erroneous topic:buildsystem Issue that applies to the buildsystem of the module, like modifying or improving the buildsystem topic:core Issue that applies to core functions, fundamental to the rest of the module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants